Bug 184290

Summary:	Bump-Request for net-nds/jxplorer-3.2
Product:	Gentoo Linux	Reporter:	Heiko Helmle <helman>
Component:	Current packages	Assignee:	Java team <java>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	ebuild for jxplorer-3.2 - briefly modified from 3.1-r4 Patch for jxplorer ebuild 3.1-r4 to 3.2

Description Heiko Helmle 2007-07-05 12:59:32 UTC

I commented out the jxplorer-gentoo.patch and the rm dsml/*.jar and then the ebuild builds fine (and seems to use the correct directory - so the patch doesn't seem to be necessary any more)

jxplorer itself seems to work fine with the attached ebuild.

Reproducible: Always

Comment 1 Heiko Helmle 2007-07-05 13:00:29 UTC

Created attachment 123952 [details]
ebuild for jxplorer-3.2 - briefly modified from 3.1-r4

Comment 2 Petteri Räty (RETIRED) gentoo-dev

2007-07-05 18:09:15 UTC

(In reply to comment #1)
> Created an attachment (id=123952) [edit]
> ebuild for jxplorer-3.2 - briefly modified from 3.1-r4
> 

Please attach diff in the future as it's easier for us developers to comment on.

Comment 3 Heiko Helmle 2007-07-06 06:19:39 UTC

Created attachment 124029 [details, diff]
Patch for jxplorer ebuild 3.1-r4 to 3.2

Here's the diff - I will keep that in mind for the future.

Comment 4 Petteri Räty (RETIRED) gentoo-dev

2007-07-21 11:25:57 UTC

(In reply to comment #3)
> Created an attachment (id=124029) [edit]
> Patch for jxplorer ebuild 3.1-r4 to 3.2
> 
> Here's the diff - I will keep that in mind for the future.
> 

I don't think we can just comment out the patch. That would make the settings directory change from .jxplorer back to ${HOME}/jxplorer. We really should make a patch with detecting unix and in that case set it to .jxplorer and send it upstream.

Comment 5 Heiko Helmle 2007-07-23 08:10:29 UTC

Hmm... I didn't look at the code (i wouldn't understand it anyway), but i commented out the patch, emerged and it's still using my .jxplorer directory.

Maybe upstream fixed it...

Comment 6 Petteri Räty (RETIRED) gentoo-dev

2007-07-24 11:05:45 UTC

(In reply to comment #5)
> Hmm... I didn't look at the code (i wouldn't understand it anyway), but i
> commented out the patch, emerged and it's still using my .jxplorer directory.
> 
> Maybe upstream fixed it...
> 

Not really. I took a look at our starter script and it changes cwd to .jxplorer and the code by default looks at cwd. Any way it is bumped now.