Bug 183768

Summary:	net-dns/totd fails to compile due to -Werror in Makefile
Product:	Gentoo Linux	Reporter:	Karsten Baumgarten <karsten.baumgarten>
Component:	[OLD] Server	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	trivial
Priority:	High
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch for net-dns/totd-1.5.1 Fixed ebuild

Description Karsten Baumgarten 2007-06-30 21:02:50 UTC

net-dns/totd has -Werror in its Makefile.in. Since gcc (4.1.2) issues a couple of warnings during compilation, emerging the package fails.

Reproducible: Always

Steps to Reproduce:
1. emerge totd
2.
3.

Actual Results:  
cc1: warnings being treated as errors
request.c: In function 'request_start':
request.c:73: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness
request.c:148: warning: pointer targets in passing argument 2 of 'sprint_inet' differ in signedness
request.c: In function 'do_forward':

...

request.c: In function 'collect_ns_socks':
request.c:814: warning: pointer targets in assignment differ in signedness
make: *** [request.o] Error 1
make: *** Waiting for unfinished jobs....
 * 
 * ERROR: net-dns/totd-1.5.1 failed.
 * Call stack:
 *   ebuild.sh, line 1642:   Called dyn_compile
 *   ebuild.sh, line 988:   Called qa_call 'src_compile'
 *   ebuild.sh, line 44:   Called src_compile
 *   totd-1.5.1.ebuild, line 26:   Called die


Expected Results:  
Compilation finishes, showing a couple of warnings in the process.

Comment 1 Karsten Baumgarten 2007-06-30 21:03:58 UTC

Created attachment 123482 [details, diff]
Patch for net-dns/totd-1.5.1

Comment 2 Karsten Baumgarten 2007-06-30 21:05:11 UTC

Created attachment 123484 [details]
Fixed ebuild

This ebuild applies the proposed patch.

Comment 3 Santiago M. Mola (RETIRED) gentoo-dev

2007-10-06 15:23:38 UTC

Fixed, thanks!