Summary: | hercules-215.ebuild (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Todd Wright <geekasylum> |
Component: | New packages | Assignee: | Tod M. Neidt (RETIRED) <tod> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | 1.1a | ||
Hardware: | x86 | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | hercules-2.15.ebuild (New Package) |
Description
Todd Wright
2002-04-16 10:17:03 UTC
Created attachment 578 [details]
hercules-2.15.ebuild (New Package)
Hi! Looks good. Some minor comments, 1. If RDEPEND is unspecified, it is assumed to be the same as DEPEND 2. The src_unpack function is unnecessary in this ebuild ( you can just remove it). It appears that you have re-specified the default behaviour. 3. There exists a dohtml helper script, see /usr/lib/portage/bin/dohtml For my benefit since I'm not familiar with this package, could you give me the reader's digest version for necessity of unsetting CFLAGS and CXXFLAGS Thanks for the contribution! Thanks for the tips, especially the one about dohtml, ive only just started to read through /usr/lib/portage/bin recently and these arent really docuumented in detail in the developer howto. I did the CFLAGS resetting stuff because the developers added an optimisation check to the configure script that overrides what the user specified in make.conf (see configure.ac in the unpacked source - look for AC_ARG_ENABLE). What I did makes configure set CFLAGS to the users make.conf setting. I could probably have achieved the same thing with 'make -e' but I only wanted to override this one variable (CFLAGS). The bulk of the developers are not familiar with autoconf and this was generally seen as an 'optimise=on/off' switch. Gentoo on the other hand is optimised from the start. I would appreciate your thoughts on this as I am no compiler expert, and I have come across another new package where I have used a similar technique to pass the Gentoo optimisations through to the compiler. If theres a better way, it would be handy to know. I just hate seeing compiles go by with simply -O2 when I have specified a particular optimisation. Committed to CVS. Thanks for your contribution! |