Bug 183037 – net-misc/nxclient-3.0.0 broken icons

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Henning Schild 2007-06-24 11:31:01 UTC]

The latest (unstable) ebuild does not install the icons and creates desktop entries without icons.

I will attach a patch against this ebuild.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Henning Schild 2007-06-24 11:31:44 UTC]

--- /usr/portage/net-misc/nxclient/nxclient-3.0.0.ebuild        2007-06-21 22:15:48.000000000 +0200
+++ /usr/local/portage/net-misc/nxclient/nxclient-3.0.0.ebuild  2007-06-24 13:18:25.000000000 +0200
@@ -51,10 +51,17 @@

        dodir /usr/NX/share
        cp -R share ${D}/usr/NX
-
-       # Add icons/desktop entries (missing in the tarball)
-       doicon share/icons/*.png
-       make_desktop_entry "nxclient" "NX Client" nx-desktop.png
-       make_desktop_entry "nxclient -admin" "NX Session Administrator" nxclient-admin.png
-       make_desktop_entry "nxclient -wizard" "NX Connection Wizard" nxclient-wizard.png
+       for x in 48 32 22 16 ; do
+               dir=/usr/share/icons/hicolor/${x}x${x}/apps/
+               dodir $dir
+               for y in admin desktop icon wizard ; do
+                       name=nxclient-${y}.png
+                       dosym /usr/NX/share/icons/${x}x${x}/${name} ${dir}/${name}
+                       unset name
+               done
+               unset dir
+       done
+       make_desktop_entry "nxclient" "NX Client" nxclient-icon
+       make_desktop_entry "nxclient -admin" "NX Session Administrator" nxclient-admin
+       make_desktop_entry "nxclient -wizard" "NX Connection Wizard" nxclient-wizard
 }

[Comment 2 Bernard Cafarelli 2007-06-25 12:10:28 UTC]

Thanks, the missing icons were already fixed in portage, but this solution is better! Fixed in CVS

[Comment 3 Henning Schild 2007-06-25 18:14:55 UTC]

I think you should change the version to -r1. That way anyone who installed the broken version will get the fix with the next update. If you dont the bug will only be fixed for people who remerge because they know about the problem.

[Comment 4 Bernard Cafarelli 2007-06-29 13:19:38 UTC]

The icons were fixed days before I switched to this new method. Also, I'd prefer to keep the -rX releases for upstream bumps (all 3.0 releases will be called 3.0.0, only the internal release number changes), not only for icons