| Summary: | gentoo-bashcomp should use 'source' to grab make.conf vars | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jason Dusek <jason.dusek> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | gianni.costanzi, ingmar, shell-tools, tristan |
| Priority: | High | Keywords: | InVCS |
| Version: | 2006.1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Uses 'source' instead of 'sed' in '_portdir()' | ||
|
Description
Jason Dusek
2007-06-21 19:02:52 UTC
Created attachment 122721 [details, diff]
Uses 'source' instead of 'sed' in '_portdir()'
portageq ? Hmm well I first of all fail to see what kind of flexibility is sourcing the file supposed to bring, as opposed to sed. (In reply to comment #3) > I first of all fail to see what kind of flexibility is sourcing the > file supposed to bring, as opposed to sed. It is syntactically legal to define make.conf vars on more then one line, but it messes up the bash completion script -- you get a hard to trace error. That's why I changed it (and still use a modded up gentoo-bashcomp). I don't like files with more than 78 columns :) (In reply to comment #2) > portageq ? What? It could get the variables by running portageq but it is a bit slow. *** Bug 187678 has been marked as a duplicate of this bug. *** (In reply to comment #3) > Hmm well I first of all fail to see what kind of flexibility is sourcing the > file supposed to bring, as opposed to sed. > another thing; there would need to be a alarge amount of hacking in order to get the correct behaviour if you have local overlays and layman overlays where you end up with PORTDIR_OVERLAY="$PORTDIR_OVERLAY $FOOBAR" or some other form of variable assignment (FOO+=$BAR) and whatnot. the patch works perfectly. ++ Fixed, thanks. |
