Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 182412

Summary: app-emacs/ebuild-mode missing keywords eautoreconf and cvs_src_unpack
Product: Gentoo Linux Reporter: Rork <rork>
Component: Current packagesAssignee: Emacs project <emacs>
Status: RESOLVED FIXED    
Severity: minor Keywords: InVCS
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch against ebuild-mode 1.5-r2

Description Rork 2007-06-17 21:27:39 UTC
ebuild-mode 1.5-r2 doesn't highlight "eautoreconf" and "cvs_src_unpack" as it should.

Reproducible: Always

Steps to Reproduce:
1. Open emacs-cvs-23.0.0-r6.ebuild in Emacs

Actual Results:  
"cvs_src_unpack" at the beginning of src_unpack() is not highlighted. Neither is "eautoreconf" at the end of that same function.

Expected Results:  
Both "cvs_src_unpack" and "eautoreconf" should be highlighted like "einfo", "epatch", etc.
Comment 1 Rork 2007-06-17 21:28:37 UTC
Created attachment 122362 [details, diff]
Patch against ebuild-mode 1.5-r2

Here is a patch that fixes the problem.
Comment 2 Ulrich Müller gentoo-dev 2007-06-17 22:01:24 UTC
These are not the only ones that are missing. We are going to add the keywords of all major eclasses to ebuild-mode. For the current status, you may look into our SVN repository: <http://overlays.gentoo.org/proj/emacs/browser/emacs-extra/ebuild-mode>.

Thank you for reporting, and please have some patience.
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-18 06:51:59 UTC
I added both (and many more) to SVN. Ff you have more, please point them out (and you should use universal diff format for patches, by the way).

Comment 4 Rork 2007-06-18 16:54:16 UTC
Thanks for the updated SVN version.
Comment 5 Ulrich Müller gentoo-dev 2007-06-21 20:56:57 UTC
This is included in version 1.6, released today. Please note that app-emacs/ebuild-mode has been renamed to app-emacs/gentoo-syntax.
Comment 6 Rork 2007-06-22 04:56:52 UTC
Great, thank you.