Bug 182328 – gnome-base/gnome-vfs-2.16.3 fail compilation on Gentoo/FreeBSD

• Product: Gentoo/Alt
• Status: RESOLVED FIXED

[Description MT 2007-06-17 13:48:33 UTC]

gnome-vfs-2.16.3 fail the compilation due to a wrong include statement that do not exists on FreeBSD:

 -MP -MF .deps/gnome-vfs-hal-mounts.Tpo -c gnome-vfs-hal-mounts.c  -fPIC -DPIC -o .libs/gnome-vfs-hal-mounts.o
gnome-vfs-hal-mounts.c:35:27: error: sys/sysmacros.h: No such file or directory
gmake[3]: *** [gnome-vfs-hal-mounts.lo] Error 1
gmake[3]: *** Waiting for unfinished jobs....
gnome-vfs-pty.c: In function '_gnome_vfs_pty_run_on_pty':
gnome-vfs-pty.c:311: warning: implicit declaration of function 'login_tty'
 i686-gentoo-freebsd6.2-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -pthread -DORBIT2=1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libxml2 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -DXDG_PREFIX=_gnome_vfs_xdg -DDBUS_API_SUBJECT_TO_CHANGE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_LARGEFILE64_SOURCE -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -DG_DISABLE_DEPRECATED -DGNOME_VFS_PREFIX=\"/usr\" -DGNOME_VFS_BINDIR=\"/usr/bin\" -DGNOME_VFS_DATADIR=\"/usr/share\" -DGNOME_VFS_LIBDIR=\"/usr/lib\" -DGNOME_VFS_LOCALEDIR=\"/usr/share/locale\" -DGNOME_VFS_SYSCONFDIR=\"/etc\" -DG_LOG_DOMAIN=\"libgnomevfs\" -march=athlon64 -pipe -O2 -MT gnome-vfs-pty.lo -MD -MP -MF .deps/gnome-vfs-pty.Tpo -c gnome-vfs-pty.c -o gnome-vfs-pty.o >/dev/null 2>&1
gmake[2]: *** [all] Error 2
gmake[1]: *** [all-recursive] Error 1
gmake: *** [all] Error 2

[Comment 1 MT 2007-06-17 13:49:39 UTC]

Created attachment 122324 [details, diff]
gnome-vfs-2.16.3-fbsd.patch

this patch fix the compilation issue without compromising the portability of the source code on different archs.

patch reported upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=448473

[Comment 2 Diego Elio Pettenò (RETIRED) 2007-06-17 13:59:52 UTC]

If configure.ac doesn't check already for sys/sysmacros.h the patch has to be rejected, it needs to be checked to use HAVE_*_H.

[Comment 3 Gilles Dartiguelongue (RETIRED) 2007-06-17 14:07:56 UTC]

excerpt from config.h.in

/* Define to 1 if you have the <sys/sysmacros.h> header file. */
#undef HAVE_SYS_SYSMACROS_H

[Comment 4 MT 2007-06-17 15:20:15 UTC]

Created attachment 122335 [details, diff]
gnome-vfs-2.16.3-fbsd.patch

this patch add also a AC_CHECK_HEADERS into configure.h so the configure process show the checking of the libs (as required by @Flameeyes).

thank you @Flameeyes and @eva for the support.

[Comment 5 Roy Marples (RETIRED) 2007-07-06 11:24:36 UTC]

2.18 is fixed