Bug 182166

Summary:	repoman full should exit with non-zero if there's errors
Product:	Portage Development	Reporter:	Daniel Gryniewicz (RETIRED) <dang>
Component:	Repoman	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	181949, 187293
Attachments:	patch to make repoman fail when it detects errors.

Description Daniel Gryniewicz (RETIRED) gentoo-dev

2007-06-15 19:13:04 UTC

In order to script commits, I run something like:
do_something &&
repoman full &&
do_something_else &&
repoman commit

I've had issues with repoman commit not spitting errors that repoman full does; but repoman full always exits with 0 exit status, so it just breezes through.  I believe that repoman should exit with non-zero when it detects errors, even in non-commit mode.

Patch attached.

Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev

2007-06-15 19:13:33 UTC

Created attachment 122180 [details, diff]
patch to make repoman fail when it detects errors.

Comment 2 Zac Medico gentoo-dev

2007-06-15 21:39:55 UTC

Thanks, this is in svn r6857.

Comment 3 Zac Medico gentoo-dev

2007-06-16 00:21:51 UTC

This has been released in 2.1.3_rc3.