Summary: | cxxflags commented out in make.conf | ||
---|---|---|---|
Product: | Portage Development | Reporter: | William Abke <bill> |
Component: | Unclassified | Assignee: | Nicholas Jones (RETIRED) <carpaski> |
Status: | RESOLVED INVALID | ||
Severity: | normal | CC: | narada.sage |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
William Abke
2003-03-26 05:55:52 UTC
As I understand it, there are three scenarios. First is that a user does not set cflags or cxxflags in which case the following defaults are set. CFLAGS="-O2 -mcpu=i686 -pipe" CXXFLAGS="-O2 -mcpu=i686 -pipe" Second, the user sets cflags but forgets to uncomment cxxflags in which case the following are set. CFLAGS="your cflags" CXXFLAGS="-O2 -mcpu=i686 -pipe" Third, the user doesn't set cflags but the cxxflags line is uncommented by default in which case the following is set. CFLAGS="-O2 -mcpu=i686 -pipe" CXXFLAGS="" Perhaps the fact that cxxflags being commented by default is trying to avoid the third result. The ideal solution would be to instruct the user to set cflags and uncomment cxxflags when installing OS and this is on the way to being established with gentoo incorporating a supported set of cflags into their installation docs. Still, I think a point should be made to ask users to uncomment cxxflags if setting cflags. Sorry if I'm making no sense. How about a 4th scenario: I would suggest the following default: #CFLAGS="-march-pentium3 -O3 -pipe" CXXFLAGS="${CFLAGS}" That way if someone makes a change to the CFLAGS they are automatically applied to the CXXFLAGS - that seems to be what most people do anyway. Your 4th scenario is the same as my 3rd. Commenting out cflags *and* setting cxxflags=cflags results in the following being set. Verify by editing make.conf and 'emerge info'. CFLAGS="-O2 -mcpu=i686 -pipe" CXXFLAGS="" It's to fix #3 as mentioned. It stays. |