Summary: | libpng-1.2.18 nongray pixel error in links -g | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Barnett <daviebdawg> |
Component: | [OLD] Library | Assignee: | Marcelo Goes (RETIRED) <vanquirius> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | base-system, gentoo, stw |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch fixing the GRAY_WARN handler |
Description
David Barnett
2007-06-08 15:43:56 UTC
The bug is reproducable. A quick workaround is to downgrade to libpng 1.2.16. A solution is to upgrade to libpng >=1.2.19beta19 More info: Links uses png images for the fonts. It converts them to grayscale using libpng's png_do_rgb_to_gray functionality. This can return a warning or an error, if the programmer wants it to. This is set by a function png_set_rgb_to_gray_fixed(png, error_action, r, g) where error_action=1 indicates to ignore all nongray pixels. In libpng 1.2.17beta2 they changed the evaluation of this error_action, causing it to always give an error, which causes links to abort, if it tries to display a character that was not encoded in a grayscale png-file. E.g. & #9660 ; is used on Google. Took me some time to find that out. The good news: This bug in libpng has already been found and removed in version 1.2.19beta19 [June 28, 2007]. We should mark everything in between to be buggy. post the diff and i'll add it to 1.2.18-r1 Created attachment 124398 [details, diff]
Patch fixing the GRAY_WARN handler
Made from the diffs between libpng-1.2.18 and libpng-1.2.19beta19, but stripped to contain only the error handler for the GRAY_WARN and GRAY_ERR flags.
Alright, that's the patch. Worked fine for me here. (In reply to comment #4) > Alright, that's the patch. Worked fine for me here. > I tested this patch, works fine. thanks Steffen, 1.2.18-r1 now in the tree with that patch |