Summary: | media-gfx/graphviz missing PNG/JPEG support unless media-libs/gd was built w/ USE="png jpeg" (was: media-libs/libdvbpsi-0.1.5 failed w/ USE=doc) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Austin McKinley <amckinle> |
Component: | Current packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jakub, mjo, tm |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Proposed patch to check /usr/bin/dot for PNG support before building documentation |
Description
Austin McKinley
2007-06-06 23:40:33 UTC
For my system, /usr/bin/dot from media-gfx/graphviz-2.12 does have support for png. From looking at configure.ac for graphviz, it appears to have PNG support if you installed media-libs/gd with png support. Unlike graphviz, gd does have a USE=png flag. If I am reading this right, USE=doc in media-libs/libdvbpsi relies on graphviz having been built with a gd with USE=png. Checking for this will not be easy since a user could theoretically do: USE=-png emerge media-libs/gd emerge media-gfx/graphviz USE=png emerge media-libs/gd emerge media-gfx/libdvbpsi In such an order, 'built_with_use media-libs/gd png' would return true, even though (as best I can tell without rebuilding to test this), graphviz would NOT have png support since it had not been rebuilt with the new USE flag for gd. It may be easier to address this bug by patching graphviz to control PNG support directly, rather than through the support in gd. If graphviz cannot be easily patched to do that, perhaps it would be sufficient to add a USE=png flag to graphviz with logic like: if use png && ! built_with_use media-libs/gd png ; then eerror "PNG support in graphviz requires PNG support in media-libs/gd." eerror "Set USE=png in media-libs/gd or USE=-png in graphviz." die "Missing png USE-flag for media-libs/gd" fi Then packages could detect whether graphviz had support for PNG in a slightly less roundabout way. Once detected, the packages using graphviz could either abort or turn off the functionality requiring PNG support. Created attachment 121631 [details, diff] Proposed patch to check /usr/bin/dot for PNG support before building documentation This patch modifies the libdvbpsi-0.1.5.ebuild to check whether /usr/bin/dot can create PNG files. If dot cannot, then make doc is skipped so that the ebuild does not die. This patch is not dependent on my speculation in comment #1, since it checks dot directly, rather than examining the USE flags of various supporting packages. Using the check of Kevin Pyle, but added it to pkg_setup, and die there with nice error message. *** Bug 195533 has been marked as a duplicate of this bug. *** Reopen and re-assign to graphviz maintainers. The suggestion in Comment #1 still sounds better than the current state, but this graphviz configure stuff plain sucks. Same crap with jpeg, btw. Fixed in 2.16.1 *** Bug 287377 has been marked as a duplicate of this bug. *** |