Bug 180800 – dev-java/janino (new ebuild)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Philipp Hagemeister 2007-06-03 23:06:33 UTC]

An ebuild for Janino. Due to the high version number, this is marked as stable (if this is wrong for a new ebuild, please comment so).

"Janino is a compiler that reads a JavaTM  expression, block, class body, source file or a set of source files, and generates JavaTM bytecode that is loaded and executed directly. Janino is not intended to be a development tool, but an embedded compiler for run-time compilation purposes, e.g. expression evaluators or "server pages" engines like JSP. "

Reproducible: Always

[Comment 1 Philipp Hagemeister 2007-06-03 23:08:57 UTC]

Created attachment 121085 [details]
The whole proposed tree part

Extract this to your local overlay to test Janino.

[Comment 2 Philipp Hagemeister 2007-06-03 23:09:40 UTC]

Created attachment 121087 [details]
Janino 2.5.7 ebuild

[Comment 3 Petteri Räty (RETIRED) 2007-06-04 08:21:00 UTC]

(In reply to comment #0)
> An ebuild for Janino. Due to the high version number, this is marked as stable
> (if this is wrong for a new ebuild, please comment so).
> 

It is. All new ebuilds go in as ~arch with no exceptions. You can't for example say that your ebuild itself is not broken until it's properly tested.

# doc: Install additional javadoc (plus README and LICENSE to the doc directory)

Always install README and never install LICENSE (there is a copy already in /usr/portage/licenses 

SRC_URI="http://janino.net/download/janino-${PV}.zip"

s/janino-${PV}/${P}/

DEPEND="${RDEPEND}
	>=virtual/jdk-1.2

It's pretty much impossible to emerge anything without needing a 1.4 (ant-core requires that I think) so use >=virtual/jdk-1.4 because that means you get 1.4 bytecode instead of 1.2 and we never test earlier JDKs any way.

	dev-java/ant-core
	app-arch/zip"

ant-core is added automatically by inheriting java-ant-2 and app-arch/zip doesn't seem used by the ebuild. java-pkg_dosrc does needed but you should put JAVA_PKG_IUSE="doc source" before inherit and the eclasses will take care of adding the proper depend entries.

S=${WORKDIR}/${PN}-${PV}

This is the default (as in S=${WORKDIR}/${P}

src_compile() {
	eant jar javadoc || die
}

Just don't add src_compile at all and the default src_compile in java-pkg-2_src_compile will automatically handle this case for you.

	dodir /usr/share/${PN}
	
	java-pkg_jarinto /usr/share/${PN}

these happen automatically

	if use doc; then
		java-pkg_dojavadoc "${S}/build/javadoc"
	fi

use doc && java-pkg_dojavadoc "${S}/build/javadoc"
and the same for java-pkg_dosrc

Thanks for the work so far.

[Comment 4 Petteri Räty (RETIRED) 2007-06-04 08:22:03 UTC]

(In reply to comment #1)
> Created an attachment (id=121085) [edit]
> The whole proposed tree part
> 
> Extract this to your local overlay to test Janino.
> 

Never add these tarballs the bugzilla. People who want to use ebuilds from bugzilla should know how to create the digests themselves. Please attach the patch you are using to this bug as text/plain

[Comment 5 Philipp Hagemeister 2007-06-04 14:59:14 UTC]

Created attachment 121140 [details]
Janino 2.5.7 ebuild

· Updated according to Betelgeuse's corrections (Thanks a lot for your feedback!). I left the insertion into /usr/share/janino instead of /usr/share/janino/lib (default) - I think this is easier to find and less confusing.
· Removed copy&paste errors
· Added app-arch/unzip dependency according to http://www.gentoo.org/proj/en/java/java-devel.xml#doc_chap4

[Comment 6 Philipp Hagemeister 2007-06-04 15:00:00 UTC]

Created attachment 121142 [details, diff]
Patch to fix hardcoded paths in build.xml

[Comment 7 Petteri Räty (RETIRED) 2007-06-05 21:24:39 UTC]

(In reply to comment #6)
> Created an attachment (id=121142) [edit]
> Patch to fix hardcoded paths in build.xml
> 

Please submit this issue upstream and file your patch there and then post the url here (I don't know if the patch is good upstream as it is but at least state why it's needed). That way we are not stuck maintaining the patch all eternity.

[Comment 8 Johann Schmitz (ercpe) (RETIRED) 2013-10-11 16:22:28 UTC]

+  11 Oct 2013; Johann Schmitz <[e-mail]> +janino-2.7.0.ebuild,
+  +metadata.xml:
+  Ebuild for janino (dependency of logback) wrt #180800

Version 2.7.0 is in the tree now.