Description
Rene Zbinden
2007-05-26 14:12:06 UTC
Created attachment 120371 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.8.ebuild
Created attachment 120373 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.8.ebuild
Corrected some formatting issues in the ebuild.
Created attachment 120374 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.8.ebuild
Changed other formatting issues in the ebuild.
Created attachment 120375 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.8.ebuild
Removed obsolete comment.
Just FYI, version 1.8.9 is out but simple ebuild rename didn't work. The compilation fails for some reason but i didn't have time to investigate it... 1.8.8 merges fine on ~amd64. Created attachment 122214 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.8.ebuild
Added ~amd64
Created attachment 122216 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.9.ebuild
On x86 architecture it compiles, so I didn't add ~amd64 to this ebuild. Since I do not have amd64 architecture I cannot test that. Paste the bug here, maybe I can help.
Created attachment 122227 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.9.ebuild
I had problems compiling 1.8.9 on ~amd64, too. But I fixed it:
Here's a new ebuild and a patch that worked for me.
Created attachment 122229 [details, diff]
media-gfx/qtpfsgui/files/dirtylangdir.patch
with the patch from Tobias, version 1.8.9 compiles fine on ~amd64 (In reply to comment #8) > Created an attachment (id=122227) [edit] > media-gfx/qtpfsgui/qtpfsgui-1.8.9.ebuild > > I had problems compiling 1.8.9 on ~amd64, too. But I fixed it: > Here's a new ebuild and a patch that worked for me. > This patch breaks the he i18n feature. Here the comments of the developer: Mmmhh... that patch breaks the i18n feature: I18NDIR has do be a symbol defined by the c++ preprocessor. This symbol expands to a string value defined by the user at the qmake step (the default is /usr/local/share/qtpfsgui/i18n). The definition happens in the project.pro at this point: contains(MAJOR_MINOR_QT_VERSION,4.2) { DEFINES += I18NDIR=\\\"$$I18NDIR\\\" #message("Detected Qt4.2 ") } else { DEFINES += I18NDIR=\"$$I18NDIR\" #message("Detected Qt4.1") } (as you can see there is an incompatibility between qt 4.1 a 4.2) now... I don't have any amd64 machine, but this is most likely an error related to the shell expansion. I see that you guys use qt-4.2.3 on gentoo. Can you please remove the comment symbol "#" at line 193 and 196 of project.pro and rerun qmake and make? Then please paste here the output. If the problem is only on amd64 architectures, can you please ask the guys to do that? I think that we have to edit project.pro to solve this problem. Can you amd64 guys do that and put the output here. Thanks in advance Rene Created attachment 122345 [details, diff]
media-gfx/qtpfsgui/files/dirtylangdir.patch
Ah ... qt-4.3.0 installed here, so the output of qmake is "Detected Qt4.1".
So I edited project.pro to work with 4.3:
contains(MAJOR_MINOR_QT_VERSION,4.1) {
DEFINES += I18NDIR=\"$$I18NDIR\"
#message("Detected Qt4.1")
} else {
DEFINES += I18NDIR=\\\"$$I18NDIR\\\"
#message("Detected Qt4.2 or later")
}
Is this correct?
Created attachment 122871 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.9.ebuild
Some further modifications to Rene's ebuild:
* The language files get generated and installed, now i18n will really work ;)
* Changed the html-documentation installation path. (couldn't get found)
I'd like to hear, how these changes work for you.
Created attachment 126540 [details]
media-gfx/qtpfsgui/qtpfsgui-1.8.11.ebuild
Version bump. Should now work without patch for amd64 systems.
this is not an official part of gentoo yet, so the security won't care about it, but you might be interested in this: Qtpfsgui "readRadianceHeader()" Buffer Overflow Vulnerability http://secunia.com/advisories/26387/ *** Bug 188673 has been marked as a duplicate of this bug. *** Created attachment 128010 [details]
media-gfx/qtpfsgui-1.8.12.ebuild
New Version. Please update, Version 1.8.11 has security issues.
I added media-gfx/qtpfsgui-1.9.0 to the tree. |