Bug 179707 – net-mail/mailgraph contains inline CSS, external CSS would make changing the appearance much easier

• Product: Gentoo Linux
• Status: RESOLVED UPSTREAM

[Description Patrick 2007-05-25 04:10:46 UTC]

Mailgraph contains a stylesheet inside the mailgraph.cgi perl script. But it would be much more convenient if the stylesheet would be external, and specific to one webapp installation.

I made a patch against mailgraph.cgi which removes the CSS code and instead links in an external stylesheet (mailgraph.css) which has to be in the MY_HTDOCSDIR. The patched ebuild copies over a default mailgraph.css which contains exactly the CSS that was in mailgraph.cgi before. Thus the default appearance of Mailgraph (as intended by the author) isn't being changed, but changing it by the user is now much easier. The user can now just copy his own CSS file over mailgraph.css or modify it.

[Comment 1 Patrick 2007-05-25 04:14:39 UTC]

Created attachment 120240 [details, diff]
Patch against mailgraph-1.13.ebuild

I hope I did that right...

[Comment 2 Patrick 2007-05-25 04:16:13 UTC]

Created attachment 120241 [details]
CSS extracted from mailgraph.cgi and stored in separate file

[Comment 3 Patrick 2007-05-25 04:17:42 UTC]

Created attachment 120242 [details, diff]
mailgraph-external-css.patch (which will be applied against mailgraph.cgi by the patched ebuild)

[Comment 4 Jakub Moc (RETIRED) 2007-05-25 05:29:13 UTC]

You should send this upstream, this is not a Gentoo-specific issue at all.

http://mailgraph.schweikert.ch/

[Comment 5 Patrick 2007-05-25 07:33:21 UTC]

Ok, I sent a suggestion upstream...