| Summary: | net-www/mplayerplug-in - Build both 32bit and 64bit plugin on AMD64 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jonas Jonsson <jonas> |
| Component: | New packages | Assignee: | Joe Jezak (RETIRED) <josejx> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | amd64, beandog, oli |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
mplayerplug-in-3.40-r1.ebuild
mplayerplug-in-3.45.ebuild mplayerplug-in-3.45.ebuild mplayerplug-in-3.45.ebuild mplayerplug-in-3.45.ebuild |
||
|
Description
Jonas Jonsson
2007-05-17 10:42:35 UTC
Created attachment 119513 [details]
mplayerplug-in-3.40-r1.ebuild
Updated ebuild to build both 32bit and 64bit.
There is however one problem, if you only have 64-bit firefox then this ebuild will require emul-x86 libs wich isn't what one wants. So if you are runing a 64-bit multilib installation but you don't use 32-bit firefox then this will pull in the emul-x86 libs for you. Hope you see the problem.
I don't know if you should opt for another use-flag or if one build the 32-bit only if you have firefox-bin installed.
This won't quite work as is because if you only have firefox-bin installed, it doesn't come with all the dev libraries needed to build mplayerplug-in (or so I've been told, I don't have an x86/amd64 system). I could probably include the binary gecko-sdk to fix this, I'll look into it I guess. Steve, any comments? (In reply to comment #2) > This won't quite work as is because if you only have firefox-bin installed, it > doesn't come with all the dev libraries needed to build mplayerplug-in (or so > I've been told, I don't have an x86/amd64 system). I could probably include > the binary gecko-sdk to fix this, I'll look into it I guess. Steve, any > comments? > I could just unmerge mozilla-firefox and see if it builds with just firefox-bin. I unmerged mozilla-firefox and it doesn't build, but if I install xulrunner it will build a 32bit plugin that works in firefox-bin. Isn't there also a problem at the other end of the plugin? Currently, it depends on mplayer, whereas I use mplayer-bin on my 64bit system to maintain compatability with the win32 codecs. This means that there are 4 combinations of mplayer and firefox you're trying to satisfy. Would it make sense to instead have an mplayerplug-in-bin ebuild? (In reply to comment #5) > Isn't there also a problem at the other end of the plugin? > > Currently, it depends on mplayer, whereas I use mplayer-bin on my 64bit system > to maintain compatability with the win32 codecs. > Well this is solved in bug #107922 , the mplayer-bin use-flag gives you the choice of either mplayer or mplayer-bin. One must decide if both plugins should be built even thought only one will be used. I think we shall build both if the system is multilib. This is probably best for the users since he/she doesn't need reemerge if he/she installs both later on. The problem is if the user only has firefox-bin, but couldn't the ebuild just depend on either xulrunner or firefox if the system is 64-bit. I added a dep for xulrunner. This should work with firefox-bin now (but I won't dep on that explicitly.) Is this enough for everyone here to get things working? I admit still, that I'm still not familiar with AMD64/multilib issues since I only work with PPC machines. :) I can now emerge mplayerplug-in (3.45), but it won't work with firefox-bin, since it builds 64bit libraries and firefox-bin is a 32bit application. xulrunner is built 64bit as well, as you'd expect, so you can't build 32bit binaries linked against it. I think the solution to this is likely to involve having a separate mplayerplug-in-bin package. Created attachment 132651 [details]
mplayerplug-in-3.45.ebuild
You could try this updated ebuild, this will build for both firefox and firefox-bin if you use amd64 and has multilibprofile.
I've just tested the new ebuild, and it works for me perfectly. Excellent stuff. Created attachment 137919 [details]
mplayerplug-in-3.45.ebuild
It makes possible to choose between firefox, seamonkey or xulrunner by USE flags.
Created attachment 137920 [details]
mplayerplug-in-3.45.ebuild
Sorry, little mistake. Here's the right one.
(In reply to comment #12) > Created an attachment (id=137920) [edit] > mplayerplug-in-3.45.ebuild > > Sorry, little mistake. Here's the right one. > Shouldn't there be a default fallback if none of the use flags are selected? Created attachment 138528 [details]
mplayerplug-in-3.45.ebuild
Sure, I think now I've covered all the possibilities.
So, we have 3 new use flags: firefox, seamonkey and xulrunner.
If USE="firefox", then defaults to mozilla-firefox, and doesn't matter any of the others USE flags.
If USE="-firefox seamonkey", defaults to seamonkey, and doesn't matter if USE="xulrunner" ou "-xulrunner"
If USE="-firefox -seamonkey xulrunner", defaults to xulrunner.
And if USE="-firefox -seamonkey -xulrunner", defaults to mozilla-firefox.
Thanks,
Aline
I added this to CVS, although I changed the dependencies a bit to simplify them: firefox - This flag always enables firefox seamonkey - This flag enables seamonkey, unless firefox is set -firefox -seamonkey - Enables xulrunner Feel free to reopen the bug if you still have problems. |
