Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 178790

Summary: dev-util/elfkickers-2.0a-r1 fails to build with recent linux-headers
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: solar (RETIRED) <solar>
Status: RESOLVED FIXED    
Severity: normal CC: ewfalor, hanno, pat, pva
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 159304    
Attachments: swap linux/elf.h for elf.h in ebfc/*.c
elfkickers-toplevel-makefile-aborts-on-error.diff

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2007-05-16 17:23:39 UTC
/var/tmp/portag/dev-util/elfkickers-2.0a-r1/work/ELFkickers
/var/tmp/portag/dev-util/elfkickers-2.0a-r1/work/ELFkickers
rebind.c:11:23: error: linux/elf.h: No such file or directory


A simple sed -i -e 's:linux/elf.h:elf.h' rebind/rebind.c should fix it (ebfc/ subdirectory also make the same mistake, but I don't think the brainfuck compiler gets built right now anyway).

For what it's worth, the Makefile does not abort on error, so the ebuild fails in the install phase instead.

HTH,
Diego
Comment 1 solar (RETIRED) gentoo-dev 2007-05-16 19:38:27 UTC
Fixed this and did a mass of other changes and cleanups. elfls and rebind now work 
on 64bit bins. Please try elfkickers-2.0a-r2.ebuild and reopen if problem 
continues.
Comment 2 Pat Erley 2007-05-17 02:22:46 UTC
I'm still suffering from this on x86, reopening.
Comment 3 solar (RETIRED) gentoo-dev 2007-05-17 02:27:19 UTC
(In reply to comment #2)
> I'm still suffering from this on x86, reopening.


I over looked ebfc on x86. Let me update that in -r3
Comment 4 Mark Glines 2007-06-02 00:04:30 UTC
Created attachment 120910 [details, diff]
swap linux/elf.h for elf.h in ebfc/*.c

(In reply to comment #3)
> I over looked ebfc on x86. Let me update that in -r3

Here's a patch.  Builds cleanly for me on x86 after this patch is applied.

Mark
Comment 5 Mark Glines 2007-06-02 00:05:42 UTC
Created attachment 120912 [details, diff]
elfkickers-toplevel-makefile-aborts-on-error.diff

(In reply to comment #0)
> For what it's worth, the Makefile does not abort on error, so the ebuild fails
> in the install phase instead.

And here's a patch to fix the Makefile.  With this patch, "make" aborts as it should, rather than continuing the loop.

Mark
Comment 6 Andrea Franceschini 2007-07-01 10:06:47 UTC
Is this -r3 going to be released soon? It seems it's more than a month long since it has been announced and this bug is still annoying me.

Thanks.
Comment 7 Alexander Huemer 2007-07-11 17:39:03 UTC
i too wonder when -r3 is released. i have the same problems like all the others on x86.
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-08-04 12:07:40 UTC
*** Bug 187716 has been marked as a duplicate of this bug. ***
Comment 9 Peter Volkov (RETIRED) gentoo-dev 2007-08-30 14:18:15 UTC
Compilation problem is fixed with sed:

+       use x86 && sed -i -e 's:linux/elf.h:elf.h:' ebfc/*.c
 
in elfkickers-2.0a-r3.ebuild.

As for Makefile, Mark, please, if you wish, open another enhancement bug and attach your patch there.