Bug 176877

Summary:	dev handbook's cvs section should cover keyword expansion in patches
Product:	Documentation	Reporter:	Andrew Ross (RETIRED) <aross>
Component:	[OLD] Developer Handbook	Assignee:	Gentoo Community Relations Team <comrel>
Status:	RESOLVED OBSOLETE
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=1&chap=4#doc_chap1
Whiteboard:
Package list:		Runtime testing required:	---

Description Andrew Ross (RETIRED) gentoo-dev

2007-05-03 04:25:47 UTC

I think it would be useful for the dev handbook's cvs section (http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=1&chap=4#doc_chap1) to include a warning about the expansion of upstream cvs keywords inside patches which are committed to cvs.

While such files are rare, they do exist (eg. http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-db/libpq/files/libpq-7.3.18-gentoo.patch), and the commit logs show I'm not the only dev to have made the mistake of adding them without the "-ko" or "-kb" argument to "cvs add" (which prevents keyword expansion from clobbering the file and causing the patch to fail).

Comment 1 Adam Feldman gentoo-dev

2016-01-28 20:27:57 UTC

Resolving as obsolete due to the fact that we no longer have to worry about the quirks of CVS and the handbook is no longer in use.