Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 176139

Summary: devmanual doesn't mention DISTDIR
Product: Documentation Reporter: Marijn Schouten (RETIRED) <hkbst>
Component: [OLD] Developer HandbookAssignee: Gentoo Community Relations Team <comrel>
Status: RESOLVED FIXED    
Severity: normal CC: dev-portage, pms
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 172589    
Attachments: devmanual patch

Comment 1 Torsten Veller (RETIRED) gentoo-dev 2007-04-26 18:07:13 UTC
1) Adding pms@ because DISTDIR is not mentioned in it.
2) Adding devrel@ because "Typically, this is /usr/portage/distfiles." is not correct. 

Portage creates a directory with symlinks to the files mentioned in src_uri so:

DISTDIR Contains the path to (the distfiles|a) directory where all the files fetched for the package are stored.


(Portage uses aalist for this, so it means all source files in AA and not only the ones needed in A. Why?)


BTW: Do we really want to describe the variables in three different documents with three different values? More values in devmanual are not up to date.
Comment 2 Brian Harring (RETIRED) gentoo-dev 2007-04-26 18:15:19 UTC
(In reply to comment #1)
> Portage creates a directory with symlinks to the files mentioned in src_uri so:
> 
> DISTDIR Contains the path to (the distfiles|a) directory where all the files
> fetched for the package are stored.
> 
> (Portage uses aalist for this, so it means all source files in AA and not only
> the ones needed in A. Why?)
Originally was using ${A}, not ${AA}; usage of ${AA} explicitly defeats the purpose of DISTDIR indirection (make ebuilds go boom if they have unstated access).

Sounds of, inadvertant regression.
Comment 3 Zac Medico gentoo-dev 2007-04-26 19:46:04 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > (Portage uses aalist for this, so it means all source files in AA and not only
> > the ones needed in A. Why?)
> Originally was using ${A}, not ${AA}; usage of ${AA} explicitly defeats the
> purpose of DISTDIR indirection (make ebuilds go boom if they have unstated
> access).
> 
> Sounds of, inadvertant regression.
> 

Fixed in svn r6437:6439.
Comment 4 Zac Medico gentoo-dev 2007-05-09 16:11:56 UTC
(In reply to comment #1)
> 1) Adding pms@ because DISTDIR is not mentioned in it.
> 2) Adding devrel@ because "Typically, this is /usr/portage/distfiles." is not
> correct. 

The above issues still remain.

> BTW: Do we really want to describe the variables in three different documents
> with three different values? More values in devmanual are not up to date.

The redundancy is annoying.  Maybe they can be unified somehow or be changed to reference one another.
Comment 5 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 18:38:51 UTC
Created attachment 138643 [details, diff]
devmanual patch

Here's what I'm adding to devmanual.  If you don't like it, or don't think it sounds correct, hit me and tell me what you think would be better.
Comment 6 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 18:43:29 UTC
(In reply to comment #4)
> > BTW: Do we really want to describe the variables in three different documents
> > with three different values? More values in devmanual are not up to date.
> 
> The redundancy is annoying.  Maybe they can be unified somehow or be changed to
> reference one another.
> 

It is annoying, and devmanual has quite a bit that the developer handbook doesn't.  It would be nice (in the long run) to make devmanual replace the developer handbook for the technical pieces.

I fixed the devmanual issue of not mentioning this variable.  Add QA back if you need us again.
Comment 7 Bo Ørsted Andresen (RETIRED) gentoo-dev 2007-12-16 18:51:15 UTC
(In reply to comment #5)
> Created an attachment (id=138643) [edit]
> devmanual patch
> 
> Here's what I'm adding to devmanual.  If you don't like it, or don't think it
> sounds correct, hit me and tell me what you think would be better.

I think it should mention that DISTDIR is strictly a read-only directory in ebuilds..
Comment 8 Ciaran McCreesh 2007-12-16 18:56:25 UTC
It isn't, at least not with EAPI 0/1. It can only become ebuild-read-only if we get src_fetch.
Comment 9 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-02-25 20:51:59 UTC
Comment on attachment 138643 [details, diff]
devmanual patch

has been applied. thanks