Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 175963

Summary: Ebuild for Raw Therapee - THe Experimental RAw Photo Editor
Product: Gentoo Linux Reporter: Bolek Tekielski <azath>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED DUPLICATE    
Severity: enhancement CC: accessor, asl, bugs_gentoo_org.Tim_OKelly, crusaderky, divanorama, ghutzl, jiri.tyr, jkt, jobbara.artalmatlan, kripton, larstobi, mkyral, mluisser, nik, sunrise, tomaszg, world.root
Priority: High Keywords: EBUILD, InOverlay
Version: unspecified   
Hardware: x86   
OS: Linux   
URL: http://www.rawtherapee.com/
Whiteboard: sunrise-overlay
Package list:
Runtime testing required: ---
Attachments: Ebuild for Raw Therapee v2 (glibc6 compatible)
Icon
Desktop entry for Raw Therapee
Desktop entry for Raw Therapee
rawtherapee-2.2.ebuild
rawtherapee-2.2-r1.ebuild
rawtherapee-2.3_beta2.ebuild
rawtherapee-2.3.ebuild
rawtherapee.png
rawtherapee-2.3.ebuild
Ebuild for development stapshot version
rawtherapee-2.4_beta1.ebuild
rawtherapee.desktop
rawtherapee-2.4_beta2.ebuild
rawtherapee-2.4_beta2.ebuild fixed missing rwz_sdk.so
rawtherapee-2.4_beta2.ebuild propper
Added missing rwz_sdk.so for x86 and minimal gcc version
rawtherapee-2.4_beta3.ebuild
rawtherapee-2.4_beta4.ebuild
rawtherapee-2.4_rc.ebuild
rawtherapee-2.4_rc2.ebuild
rawtherapee-2.4_rc2.ebuild
rawtherapee-2.4_rc2-r1.ebuild
context menu without labels
application without labels
Always install eng. lang. files patch

Description Bolek Tekielski 2007-04-25 12:47:41 UTC
Ebuild for Raw Therapee RAW images processor. Since there aren't many RAW editors for Linux I thought it might be useful to have another, even if it isn't open-source, only free.

Reproducible: Always
Comment 1 Bolek Tekielski 2007-04-25 12:49:14 UTC
Created attachment 117221 [details]
Ebuild for Raw Therapee v2 (glibc6 compatible)
Comment 2 Bolek Tekielski 2007-04-25 12:50:30 UTC
Created attachment 117222 [details]
Icon
Comment 3 Bolek Tekielski 2007-04-25 12:54:34 UTC
Created attachment 117224 [details]
Desktop entry for Raw Therapee
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-25 15:18:30 UTC
- license isn't "RawThrerapee", but BSD without any clause - developers and proper licensing... *sigh*
- src_unpack() is superfluous
- the desktop entry is at least missing the mandatory "Encoding" key:value pair, you may want to install desktop-file-utils
Comment 5 Bolek Tekielski 2007-04-25 18:45:34 UTC
Created attachment 117260 [details]
Desktop entry for Raw Therapee
Comment 6 Bolek Tekielski 2007-04-25 18:46:38 UTC
Hm. I thought that BSD license means that you have a source and you may do anything you like with it, not a binary, but I may be wrong.
Referring to _superfluous_  src_unpack() - firstly it doesn't hurt to have it, and secondly it's in official guide.
Encoding part - OK, I fixed that.
Summarizing thanks for your extremely useful and kind remarks that will definitely  make me write much better ebuilds.
Comment 7 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-26 13:19:45 UTC
Ah, didn't notice this is a proprietary applicaton. They'd take their disclaimer from the BSD license.
Comment 8 Marian Kyral 2008-01-01 22:00:57 UTC
Created attachment 139828 [details]
rawtherapee-2.2.ebuild

Updated to ver 2.2.
Comment 9 Tomasz Golinski 2008-01-05 13:12:51 UTC
You could add "~amd64" flag with at least these additional dependencies:
app-emulation/emul-linux-x86-gtklibs
app-emulation/emul-linux-x86-xlibs
Comment 10 Marian Kyral 2008-01-05 22:24:07 UTC
Created attachment 140238 [details]
rawtherapee-2.2-r1.ebuild

~amd64 keyword added.
Comment 11 Marian Kyral 2008-01-05 23:09:50 UTC
Created attachment 140239 [details]
rawtherapee-2.3_beta2.ebuild

A newest beta ebuild. See http://www.rawtherapee.com/forum/viewtopic.php?t=484&postdays=0&postorder=asc&start=0 for details.
Comment 12 Marian Kyral 2008-02-18 19:43:49 UTC
Created attachment 143894 [details]
rawtherapee-2.3.ebuild

A version 2.3 is out.
Comment 13 Marian Kyral 2008-02-18 19:45:12 UTC
Created attachment 143895 [details]
rawtherapee.png

... with a nice new icon :-)
Comment 14 DrSlony 2008-05-09 09:38:31 UTC
RT-2.4 is out
Comment 15 Marian Kyral 2008-05-09 16:58:20 UTC
(In reply to comment #14)
> RT-2.4 is out
> 
No, it is only first milestone of 2.4. Not all features are implemented, some of them are incomplete. It also process incorrectly Nikon raw files.
Comment 16 Ed Wiget 2008-05-18 15:54:12 UTC
(In reply to comment #12)
> Created an attachment (id=143894) [edit]
> rawtherapee-2.3.ebuild
> 
> A version 2.3 is out.
> 

on the ebuild, there are two typo's, that will give error messages on digest build:  rawtherapee # ebuild rawtherapee-2.3.ebuild digest
RDEPEND: amd64? ( app-emulation/emul-linux-x86-xlibs app-emulation/emul-linux-x86-baselibs app-emulation/emul-linux-x86-medialibs app-emulation/emul-linux-x86-compat app-emulation/emul-linux-x86-gtklibs ) x86? (>=x11-libs/gtk+-2.10 >=sys-libs/glibc-2.4 >=media-libs/jpeg-6b-r7 >=media-libs/tiff-3.8.2-r2 >=media-libs/libpng-1.2.15)
missing space by parenthesis: '(>'

Instead of re-upping the ebuild, here are the fixes:
Find line: 
 x86? (>=x11-libs/gtk+-2.10
and add a space after the ( so it looks like this:
 x86? ( >=x11-libs/gtk+-2.10

and also find line:
 >=media-libs/libpng-1.2.15)"
and add a space after the 5 so it looks like this:
 >=media-libs/libpng-1.2.15 )"
Comment 17 Markus Luisser 2008-05-23 02:54:22 UTC
Created attachment 154027 [details]
rawtherapee-2.3.ebuild

Updated ebuild - see comment #16. I also corrected a typo in LICENSE and added a comment on how to resolve this bug (which I ran into):

http://www.rawtherapee.com/forum/viewtopic.php?t=664&highlight=outofrange

Works on amd64.
Comment 18 Valery Novikov 2008-10-07 12:47:10 UTC
Created attachment 167535 [details]
Ebuild for development stapshot version

Updated to ver 2.4-r1.
Comment 19 Günther Hutzl 2008-10-08 18:34:22 UTC
(In reply to comment #18)
> Created an attachment (id=167535) [edit]
> Ebuild for development stapshot version
> 
> Updated to ver 2.4-r1.
> 

I have a problem when building the Manifest:

ebuild rawtherapee-2.4-r1.ebuild  digest
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 4:
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 6:
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 10:
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 16:
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 28:
: command not foundmedia-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 31:
'usr/local/portage/media-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 32: syntax error near unexpected token `{
'usr/local/portage/media-gfx/rawtherapee/rawtherapee-2.4-r1.ebuild: line 32: `src_unpack() {
 *
 * ERROR: media-gfx/rawtherapee-2.4-r1 failed.
 * Call stack:
 * ebuild.sh, line 1869:  Called die
 * The specific snippet of code:
 * source "${EBUILD}" || die "error sourcing ebuild"
 * The die message:
 * error sourcing ebuild
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * This ebuild is from an overlay: '/usr/local/portage/'
 *
!!! getFetchMap(): aux_get() error reading media-gfx/rawtherapee-2.4-r1; aborting.

I cannot find out what the problem is...
Any idea?
Comment 20 Marian Kyral 2008-10-27 21:49:49 UTC
Created attachment 170037 [details]
rawtherapee-2.4_beta1.ebuild

Version 2.4 beta1 is out. There is native 64bit version, 32bit libraries not needed any more on amd64.

Ebuild updated to use EAPI2, will works only with newest portage.
Comment 21 Marian Kyral 2008-10-27 21:51:41 UTC
Created attachment 170039 [details]
rawtherapee.desktop

A new desktop file. RT is now started by rtstart command.
Comment 22 Marian Kyral 2008-11-13 19:36:27 UTC
Created attachment 171653 [details]
rawtherapee-2.4_beta2.ebuild

New version.
Comment 23 Bjoern Olausson 2008-12-07 14:50:55 UTC
I get an error when starting RT on 32Bit gentoo:

/opt/RawTherapee/rtstart
/opt/RawTherapee/rt: error while loading shared libraries: rwz_sdk.so: cannot open shared object file: No such file or directory

where can I find rwz_sdk.so?

kind regards
blubbi
Comment 24 Bjoern Olausson 2008-12-07 15:06:44 UTC
Created attachment 174566 [details]
rawtherapee-2.4_beta2.ebuild fixed missing rwz_sdk.so

(In reply to comment #23)
> 
> where can I find rwz_sdk.so?
>

Okay, unpacking the rawtherapee tgz reveals the rwz_sdk.so

I guess it shoud be placed in /opt/RawTherapee/

So you should add

        doexe rwz_sdk.so || die

to the ebuild.

Attached the fixed ebuild.

Thought I now get:
blub@stargazer $ /opt/RawTherapee/rtstart
/opt/RawTherapee/rt: /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/libstdc++.so.6: version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/rt)
/opt/RawTherapee/rt: /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/libstdc++.so.6: version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/librtengine.so)

kind regards
blubbi
Comment 25 Marian Kyral 2008-12-07 15:18:47 UTC
(In reply to comment #24)
> Created an attachment (id=174566) [edit]
> rawtherapee-2.4_beta2.ebuild fixed missing rwz_sdk.so
> 
> (In reply to comment #23)
> > 
> > where can I find rwz_sdk.so?
> >
> 
> Okay, unpacking the rawtherapee tgz reveals the rwz_sdk.so
> 
> I guess it shoud be placed in /opt/RawTherapee/
> 
> So you should add
> 
>         doexe rwz_sdk.so || die
> 
> to the ebuild.
> 
> Attached the fixed ebuild.
> 
> Thought I now get:
> blub@stargazer $ /opt/RawTherapee/rtstart
> /opt/RawTherapee/rt: /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/libstdc++.so.6:
> version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/rt)
> /opt/RawTherapee/rt: /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/libstdc++.so.6:
> version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/librtengine.so)
> 
> kind regards
> blubbi
> 

Hi,
thanks for your fix. It will be not so easy, as this library is not needed by amd64.

Unfortunately, you are using too old gcc. I'm not sure, which version is of gcc is minimal. I'm using 4.3.2.
Comment 26 Bjoern Olausson 2008-12-07 15:34:22 UTC
(In reply to comment #25)
> Hi,
> thanks for your fix. It will be not so easy, as this library is not needed by
> amd64.
> 
> Unfortunately, you are using too old gcc. I'm not sure, which version is of gcc
> is minimal. I'm using 4.3.2.
> 

Okay, than just do

if [ "${ARCH}" = "x86" ]
  doexe rwz_sdk.so || die
fi

and add

add gcc-4.3 in the RDEPEND section.

kind regards
Bjoern
Comment 27 Bjoern Olausson 2008-12-07 15:37:10 UTC
Created attachment 174570 [details]
rawtherapee-2.4_beta2.ebuild propper

see previous post
Comment 28 Marian Kyral 2008-12-07 15:41:15 UTC
Created attachment 174572 [details]
Added missing rwz_sdk.so for x86 and minimal gcc version

> Okay, than just do
> 
> if [ "${ARCH}" = "x86" ]
>   doexe rwz_sdk.so || die
> fi
> 
> and add
> 
> add gcc-4.3 in the RDEPEND section.
> 
> kind regards
> Bjoern

I did it just now :-)

Marian
Comment 29 Bjoern Olausson 2008-12-07 15:43:24 UTC
(In reply to comment #28)
> Created an attachment (id=174572) [edit]
> 
> I did it just now :-)
> 
> Marian
> 

Toooooo late :-)
/me was faster *G*

You should nag some devs to get this into portage :-)

regards
Bjoern
Comment 30 Bjoern Olausson 2008-12-07 15:45:28 UTC
Outch, mine is missing a "then"

So keep away from mine and take the one from "Marian Kyral"

Kind regards
Bjoern
Comment 31 Marian Kyral 2008-12-07 15:48:47 UTC
(In reply to comment #30)
> Outch, mine is missing a "then"
> 
> So keep away from mine and take the one from "Marian Kyral"
> 
> Kind regards
> Bjoern
> 

Too late, but tested ;-)

Thanks for help
Marian
Comment 32 Marian Kyral 2008-12-08 20:30:31 UTC
Created attachment 174666 [details]
rawtherapee-2.4_beta3.ebuild

A third beta was released.

http://www.rawtherapee.com/?mitem=1&artid=32

Known issues: 
 * still no solution on the library dependency problems under older linux distributions
Comment 33 Marian Kyral 2008-12-26 17:23:26 UTC
Created attachment 176449 [details]
rawtherapee-2.4_beta4.ebuild
Comment 34 Marian Kyral 2009-02-01 10:01:03 UTC
Created attachment 180515 [details]
rawtherapee-2.4_rc.ebuild
Comment 35 Marian Kyral 2009-03-13 22:12:57 UTC
Created attachment 184920 [details]
rawtherapee-2.4_rc2.ebuild

RawTherapee V2.4 Release Candidate 2

March 13, 2009

The following fixes/additions have been made since the last release candidate:

    * dcraw update to 8.93/1.421
    * gtk/gtkmm update in the win32 version
    * fixed installer/uninstaller
    * fixed several small bugs
Comment 36 Marian Kyral 2009-03-17 20:06:54 UTC
Created attachment 185341 [details]
rawtherapee-2.4_rc2.ebuild

An updated ebuild, some cleanup, added linguas support.
Comment 37 Marian Kyral 2009-03-27 22:43:49 UTC
Created attachment 186493 [details]
rawtherapee-2.4_rc2-r1.ebuild

Updated dev-cpp/gtkmm dependency, fix of wrong IUSE shown by eix.
Comment 38 Marian Kyral 2009-04-05 19:26:42 UTC
Comment on attachment 186493 [details]
rawtherapee-2.4_rc2-r1.ebuild

This is now in the sunrise overlay. You can find it at:
http://overlays.gentoo.org/proj/sunrise/browser/reviewed/media-gfx/rawtherapee/

Thanks to people on #gentoo-sunrise for help with this.
Comment 39 Tomáš Chvátal (RETIRED) gentoo-dev 2009-04-05 19:40:25 UTC
Gentle touch for informing that the thing is in sunrise overlay
Comment 40 Dmitry Ivankov 2009-04-11 14:47:49 UTC
(In reply to comment #26)
> (In reply to comment #25)
> add gcc-4.3 in the RDEPEND section.

That's wrong it will just silently emerge gcc-4.3 and won't gcc-config it.
I've used gcc-config to switch from 4.1.2 to 4.3.2, reemerged rawtherapee and it resolved following error on rtstart:

/opt/RawTherapee/rt: /usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/libstdc++.so.6: version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/rt)

And I even was able to run it, but can't see any labels :(
- in rclick menu on photos only "ctrl-c" and other shortcuts are visible, but no labels
- no captions for tabs on the right toolbar and scrolls on the toolbars
Where can I post a screenshot?
Comment 41 Marian Kyral 2009-04-11 17:55:54 UTC
(In reply to comment #40)
> (In reply to comment #26)
> > (In reply to comment #25)
> > add gcc-4.3 in the RDEPEND section.
> 
> That's wrong it will just silently emerge gcc-4.3 and won't gcc-config it.
> I've used gcc-config to switch from 4.1.2 to 4.3.2, reemerged rawtherapee and
> it resolved following error on rtstart:
> 
> /opt/RawTherapee/rt: /usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/libstdc++.so.6:
> version `GLIBCXX_3.4.9' not found (required by /opt/RawTherapee/rt)
> 
> And I even was able to run it, but can't see any labels :(
> - in rclick menu on photos only "ctrl-c" and other shortcuts are visible, but
> no labels
> - no captions for tabs on the right toolbar and scrolls on the toolbars
> Where can I post a screenshot?
> 

Hi,
upgrade to new gcc is not just switch compiler in gcc-config. The best way is to reemerge all packages. At least system and libraries.

http://www.gentoo.org/doc/en/gcc-upgrading.xml

Screenshot you can post just here, there is "Create a New Attachment (proposed patch, testcase, etc.)" below files list.
Comment 42 Dmitry Ivankov 2009-04-11 18:25:09 UTC
Created attachment 188006 [details]
context menu without labels
Comment 43 Dmitry Ivankov 2009-04-11 18:27:08 UTC
Created attachment 188008 [details]
application without labels

Also there are few messages in console when launching rtstart:
Xlib:  extension "RANDR" missing on display ":0.0".

(rt:29561): Gtk-WARNING **: Unable to locate theme engine in module_path: "clearlooks",
processing file /opt/RawTherapee/profiles/crisp.pp2...
processing file /opt/RawTherapee/profiles/neutral.pp2...
processing file /opt/RawTherapee/profiles/default.pp2...
Comment 44 Dmitry Ivankov 2009-04-11 18:36:32 UTC
(In reply to comment #41)
> Hi,
> upgrade to new gcc is not just switch compiler in gcc-config. The best way is
> to reemerge all packages. At least system and libraries.
> 
> http://www.gentoo.org/doc/en/gcc-upgrading.xml
Thanks, I thought it's not needed for not too system application.

But anyway it'd be better if ebuild will
- fail if current gcc is too old with a message like "upgrade your gcc [link]".
- probably drop RDEPEND (do other packages use it for gcc?) because it's a waste of time for those who don't want gcc upgade now and incomplete for those who decide to upgrade now
Comment 45 Marian Kyral 2009-04-11 19:27:16 UTC
(In reply to comment #42)
> Created an attachment (id=188006) [edit]
> context menu without labels
> 

Well, your LINGUAS is not supported by rawtherapee. The english-us language file should be always installed.
Comment 46 Marian Kyral 2009-04-11 19:33:24 UTC
Created attachment 188012 [details, diff]
Always install eng. lang. files patch

A patch for ebuild.

I'll consider the gcc check.
Comment 47 Dmitry Ivankov 2009-04-11 20:09:37 UTC
(In reply to comment #45)
> (In reply to comment #42)
> > Created an attachment (id=188006) [edit]
> > context menu without labels
> > 
> 
> Well, your LINGUAS is not supported by rawtherapee. The english-us language
> file should be always installed.
Thanks, LINGUAS=en_US emerge rawtherapee gave me the labels. In fact my LINGUAS is empty and locale is en_US.UTF8.

And looks like it works without recompiling the world with newer gcc, only rt is compiled gcc-4.3.2 :)

 
 

Comment 48 Dmitry Ivankov 2009-04-11 20:15:54 UTC
(In reply to comment #47)
> And looks like it works without recompiling the world with newer gcc, only rt
> is compiled gcc-4.3.2 :)

Sorry, too quick check - it will fail to start if gcc is switched back to 4.1.2 by gcc-config - old libstdc++ is pulled at start :(
Comment 49 Dmitry Ivankov 2009-04-12 09:50:29 UTC
D'oh it is a binary application so "compiling" doesn't make sense :))
So to start it one can fire smth like this if his system gcc is too old and newer gcc is installed:
LD_LIBRARY_PATH=/usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/ /opt/RawTherapee/rt
Comment 50 Hanno Böck gentoo-dev 2010-01-06 18:09:41 UTC
Quick note, raw therapee is now free software (GPLv3):
http://www.rawtherapee.com/?mitem=3&artid=47
Comment 51 Marian Kyral 2010-01-06 21:28:43 UTC
(In reply to comment #50)
> Quick note, raw therapee is now free software (GPLv3):
> http://www.rawtherapee.com/?mitem=3&artid=47
> 

Yes, I'm trying to make a live ebuild, but RT needs some more work as there is no possible to change the install directory now. 
Comment 52 Jan Kundrát (RETIRED) gentoo-dev 2010-02-02 01:14:41 UTC
I've tried to create a live ebuild, but upstream uses cmake in a rather weird way. Linking to binaries shipped in SVN, not supporting out-of-tree builds,...
Comment 53 Marian Kyral 2010-02-02 02:42:54 UTC
(In reply to comment #52)
> I've tried to create a live ebuild, but upstream uses cmake in a rather weird
> way. Linking to binaries shipped in SVN, not supporting out-of-tree builds,...
> 

There are two patches that polish the build system, we need to wait till some of it will be commited. The issue is the rawzor library.
Comment 54 crusaderky 2010-08-18 22:29:35 UTC
Both rawtherapee-2.4_rc2-r1 and 2.4.1 crash on start with the following message:

terminate called after throwing an instance of 'Gdk::PixbufError'

On the official forum [1] it's explained it's because I've got libpng-1.4, to which gtkmm is linked to, while the binary expects libpng-1.2.

[1]http://www.rawtherapee.com/forum/viewtopic.php?t=1799&sid=e2fe12d6150bc9b2aca69c5dd29097fe

Solutions:
1)provide a local, binary version of libpng-1.2, gtkmm and whatever else is needed  (the whole GTK set, I guess)
2)compile RawTherapee-3.0-alpha1 from sources, which are at last provided by the author.
That would obviously mean rewriting the ebuild from scratch, as the current one is for the binary version.
Comment 55 crusaderky 2010-08-18 22:38:54 UTC
3)download a nightly build from here:
http://www.rawtherapee.com/forum/viewtopic.php?t=2101

It works flawlessly for me (running from my ~/).
I needs >=tiff-4.0 and libiptcdata.
Comment 56 Markos Chandras (RETIRED) gentoo-dev 2011-10-30 09:35:25 UTC

*** This bug has been marked as a duplicate of bug 316589 ***