Summary: | sys-apps/915resolution ~x86-fbsd ebuild/patch & keyword request | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Joe Peterson (RETIRED) <lavajoe> |
Component: | FreeBSD | Assignee: | Patrick McLean <chutzpah> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | CC: | bsd+disabled |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | FreeBSD | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ChangeLog
915resolution-0.5.3-r1.ebuild files/915resolution-0.5.3-freebsd.patch files/initd-r1 915resolution-0.5.3.ebuild files/initd-r1 915resolution-0.5.3-r1.ebuild |
Description
Joe Peterson (RETIRED)
2007-04-21 21:27:40 UTC
Created attachment 116943 [details]
ChangeLog
Created attachment 116944 [details]
915resolution-0.5.3-r1.ebuild
Created attachment 116945 [details]
files/915resolution-0.5.3-freebsd.patch
Created attachment 116946 [details]
files/initd-r1
One note: -O2 breaks this build (the assembler part), and it's not really needed anyway. I set CFLAGS to "" in the ebuild, which I have just heard is not recommended (makes sense!). So really, we should filter the -O2 flag out instead... Created attachment 116960 [details]
915resolution-0.5.3.ebuild
Now use flag-o-matic to remove various flags, since optimization breaks the assembly part of this build. This is more correct than hard-setting CFLAGS.
Created attachment 117972 [details]
files/initd-r1
Fixed issue where returned error codes (from 915resolution program) will not be remembered if not on last mode tried. Solution is to remember the last *bad* (non-zero) error code returned and return that code. Please advise if it would be better to return a fixed error code if one non-zero code is returned.
Also now insert separators between multiple modes in the log file for readability.
Comment on attachment 116960 [details]
915resolution-0.5.3.ebuild
Changing rev back to original (no -r1)
Summary change Note: new initd file is named initd-r1 in new ebuild and in attachment. I have changed the name of the ebuild back to reflect the old version number, so I am unsure how to name this initd file; leaving as-is for now; please change as appropriate when committing... Created attachment 121509 [details]
915resolution-0.5.3-r1.ebuild
Mods to ebuild (and version bump)
Comment on attachment 116943 [details]
ChangeLog
Ignore previously attached ChangeLog
Port to ~x86-fbsd, bump version, keyword this arch only, fix init.d script. Note to maintainer: please test on other archs and then re-add their keywords (thanks!) Re-opening, so we don't lose track that maintainer should test on other archs... Re-keyworded for x86, adding amd64 to CC as I don't have an amd64 machine with an intel graphics card to test with amd64 done Should be able to close this now... OK, closing. Thanks, everyone! |