Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 17232

Summary: smartmontools ebuild no honor CFLAGS
Product: Gentoo Linux Reporter: Paul Thompson <set.mailinglist>
Component: New packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: 1.4_rc1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: make smartmontools ebuild honor CFLAGS

Description Paul Thompson 2003-03-10 11:53:27 UTC
Here is (whitespace dammaged) fix:
(patch is also attached)

--- smartmontools-5.0.45.ebuild.orig    2003-03-10 11:43:53.000000000 -0500
+++ smartmontools-5.0.45.ebuild 2003-03-10 11:44:27.000000000 -0500
@@ -14,6 +14,9 @@
 S=${WORKDIR}/${MY_P}
 
 src_compile() {
+       cp Makefile Makefile.orig
+       sed -e "/^CFLAGS/c CFLAGS = -fsigned-char ${CFLAGS}" < Makefile.orig \
+               > Makefile
        emake || die
 }
Comment 1 Paul Thompson 2003-03-10 11:54:35 UTC
Created attachment 9214 [details, diff]
make smartmontools ebuild honor CFLAGS
Comment 2 SpanKY gentoo-dev 2003-03-10 12:19:45 UTC
no reason to edit the makefile ... you can just pass it on the `make` cmd line ...

http://cvs.gentoo.org/cgi-bin/viewcvs.cgi/gentoo-x86/sys-apps/smartmontools/smartmontools-5.0.45.ebuild.diff?r1=1.4&r2=1.5