Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 171962

Summary: Make repoman check ChangeLog syntax
Product: Portage Development Reporter: Petteri Räty (RETIRED) <betelgeuse>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED OBSOLETE    
Severity: normal CC: coldwind, fauli
Priority: High    
Version: 2.2   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: check_changelog.py
check_changelog.py
check_changelog.py

Description Petteri Räty (RETIRED) gentoo-dev 2007-03-23 21:24:53 UTC
Here is an example broken entry:

# $Header: /var/cvsroot/gentoo-x86/x11-libs/libXinerama/ChangeLog,v 1.27 2007/03/22 02:18:21 joshuabaergen Exp $

  22 Mar 2007; Joshua Baergen <joshuabaergen@gentoo.org>
  +libXinerama-1.0.2.ebuild:
  Version bump.  Includes new documentation and some small code tweaks.

This is missing the 

*libXinerama-1.0.2 (22 Mar 2007) 

line. Having this line is important because emerge -pl libXinerama does not work without it.
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2007-03-23 21:26:29 UTC
Created attachment 114184 [details]
check_changelog.py

Here is the logic for checking ChangeLogs. Can be run like:

find /usr/portage/ -name "ChangeLog" | xargs python changelog.py

It seems the tree is full of broken entries atm:

betelgeuse@pena ~/python $ find /usr/portage/ -name "ChangeLog" | xargs python changelog.py  | wc -l
2545
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2007-03-23 22:13:19 UTC
Created attachment 114194 [details]
check_changelog.py

Handle package names with + in them.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2007-03-24 10:51:29 UTC
Created attachment 114220 [details]
check_changelog.py

Take package moves into account and check the date syntax for *foo-1.0 (date) lines.

http://dev.gentoo.org/~betelgeuse/changelogs_syntax_errors.txt
Comment 4 Zac Medico gentoo-dev 2007-03-27 21:09:38 UTC
As discussed on irc, I'd like to add 2 new repoman checks for this:

1) Fail if a new ebuild has been added without an appropriate ChangeLog entry.
2) Warn if there are broken ChangeLog entries for previously existing ebuilds.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2007-05-24 20:42:37 UTC
(In reply to comment #4)
> 1) Fail if a new ebuild has been added without an appropriate ChangeLog entry.
> 2) Warn if there are broken ChangeLog entries for previously existing ebuilds.

 What is the status?
Comment 6 Marius Mauch (RETIRED) gentoo-dev 2007-06-23 16:45:29 UTC
Do we really want to add more stuff into the current repoman incarnation? That beast *really* needs to be rewritten.
Comment 7 Michael Orlitzky gentoo-dev 2015-11-18 18:12:58 UTC
Obsolete? Devs don't generate changelogs nowadays and repoman won't see them.
Comment 8 Michael Orlitzky gentoo-dev 2017-02-26 22:29:09 UTC
<ulm> mjo: just close it