Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 169825

Summary: mozilla fixes needed for Gentoo/FreeBSD.
Product: Gentoo/Alt Reporter: Javier Villavicencio (RETIRED) <the_paya>
Component: FreeBSDAssignee: Gentoo/BSD Team <bsd+disabled>
Status: RESOLVED FIXED    
Severity: normal CC: mozilla
Priority: High    
Version: unspecified   
Hardware: All   
OS: FreeBSD   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: mozilla-fbsd.patch

Description Javier Villavicencio (RETIRED) gentoo-dev 2007-03-07 20:52:22 UTC
This patch is needed for mozilla-firefox/thunderbird >=2, seamonkey >=1.1.1 and maybe anything that builds from mozilla sources on Gentoo/FreeBSD for them to compile and work properly.
Comment 1 Javier Villavicencio (RETIRED) gentoo-dev 2007-03-07 20:53:03 UTC
Created attachment 112468 [details, diff]
mozilla-fbsd.patch

The patch is made for firefox but applies with some fuzz to seamonkey.
I haven't tested it yet against thunderbird but it should apply there as well (and it's needed there too)
By the way, no harm done to linux since these modifications only appear inside FreeBSD conditionals.
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2007-03-07 21:28:17 UTC
(In reply to comment #1)
Yes, most of the patches apply for all the mozilla products(and if they only touch configures or makefiles they can be applied to all products, as they use the same crap build system for all of them). 

Btw the patch to nsprpub is not needed, as we don't use the included nspr/nss. How is that nss worked without patching it? Or i am missing something? 

Comment 3 Javier Villavicencio (RETIRED) gentoo-dev 2007-03-07 21:33:31 UTC
(In reply to comment #2)
> Btw the patch to nsprpub is not needed, as we don't use the included nspr/nss.
> How is that nss worked without patching it? Or i am missing something? 
> 

I grepped for configure.in's that would set _PTHREAD_LDFLAGS to -lc_r on FreeBSD, nss didn't showed in the grep, and the resulting binaries don't show libc_r.so running a scanelf -nR on the installed files, just like in vanilla freebsd.
Comment 4 Raúl Porcel (RETIRED) gentoo-dev 2007-03-07 22:52:35 UTC
(In reply to comment #3)
> I grepped for configure.in's that would set _PTHREAD_LDFLAGS to -lc_r on
> FreeBSD, nss didn't showed in the grep, and the resulting binaries don't show
> libc_r.so running a scanelf -nR on the installed files, just like in vanilla
> freebsd.
> 

I meant nspr :) What about without applying the nspr patch? Still works?
Comment 5 Javier Villavicencio (RETIRED) gentoo-dev 2007-03-08 03:34:22 UTC
(In reply to comment #4)
> 
> I meant nspr :) What about without applying the nspr patch? Still works?
> 

Hmm IIRC I still missed -lpthread in some places and the build failed by just patching the main configure.in, that's why (then) I looked for other places where it might be needed and nsprpub/configure.in came up.
Anyway, the whole patch is just fixing *very* outdated(2003/2004?) checks, I think it's fine to apply it to both files.
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2007-03-09 11:47:06 UTC
Fixed in:
mozilla-firefox 2.0.0.2, patchset 2.0.0.2-0.5
mozilla-thunderbird 2.0_beta2, patchset 2.0_beta2-0.4
seamonkey 1.1.1, patchset 1.1.1-0.2
mozilla-sunbird 0.3.1, patchset 0.3.1-0.2
xulrunner 1.8.0.4, patchset 1.8.0.4-1.0

Happy keywording!