Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 169226

Summary: xfce-base/thunar-0.8.0-r2 hard dependency on virtual/fam
Product: Gentoo Linux Reporter: Dave Armstrong <dave0x01>
Component: New packagesAssignee: XFCE Team <xfce>
Status: RESOLVED UPSTREAM    
Severity: minor    
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch to configure.in to build without fam
patch to thunar-0.8.0-r2.ebuild to support building without fam

Description Dave Armstrong 2007-03-04 03:02:43 UTC
Merging the latest xfce4 meta ebuild from ~x86 pulls thunar-0.8.0-r2, which "rdepends" on virtual/fam, which is not strictly necessary.  Considering the history of problems caused by gamin (which is merged to fulfill virtual/fam), I strongly encourage the the ebuild maintainers to make the dependency on virtual/fam optional, perhaps contingent upon the existing fam USE flag or other as seen fit, prior to introducing the affected packages into the stable branch.

Reproducible: Always
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-03-04 08:28:20 UTC
Feel free to attach a patch to make this a configure option; until then it stays as it is...

http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2007-03-04 14:01:11 UTC
Reopen when a patch has been sent to upstream. Drop us a copy too. Thanks.
Comment 3 Dave Armstrong 2007-03-10 02:31:25 UTC
Created attachment 112756 [details, diff]
patch to configure.in to build without fam
Comment 4 Dave Armstrong 2007-03-10 02:41:37 UTC
Created attachment 112758 [details, diff]
patch to thunar-0.8.0-r2.ebuild to support building without fam

These changes to the ebuild enable building thunar with or without fam, based on the presence of the "fam" USE flag.
Comment 5 Dave Armstrong 2007-03-10 02:56:53 UTC
The first attachment (thunar-0.8.0-configure.in.patch) belongs in xfce-base/thunar/files/, and will be applied during the build process by the modified ebuild (see second attachment).

I have not submitted anything upstream yet (but feel free to).
Comment 6 Josh Nichols (RETIRED) gentoo-dev 2007-03-10 06:37:35 UTC
(In reply to comment #5)
> I have not submitted anything upstream yet (but feel free to).
> 

Please submit this upstream. We rather not deviate much from upstream unless really necessary. Please re-open when it has been addressed there.