Summary: | Fluxconf ebuild (new ebuild) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stuart Bouyer (RETIRED) <stubear> |
Component: | New packages | Assignee: | Seemant Kulleen (RETIRED) <seemant> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild for fluxconf
digest for floxconf-0.6 revision to ebuild following Tod's comments |
Description
Stuart Bouyer (RETIRED)
2002-04-11 10:39:23 UTC
Created attachment 528 [details]
ebuild for fluxconf
Fluxconf is an gui config editor for fluxbox
Created attachment 529 [details]
digest for floxconf-0.6
not sure whether I'm supposed to send these or not.
GUI configuration editor for fluxbox Hi! Looked over your ebuild, but haven't tried it yet. Some feedback follows so that your ebuild can be integrated into the portage tree expeditiously when the time comes. 1. The use of the 'A=blah' is deprecated. It is not necessary, so just remove that line. 2. The explicit src_unpack() function is unnecessary in this case also. This function is usually used when patching the tarball sources is necessary. You can just remove the src_unpack function from the ebuild. 3. Check the depedencies of the executable by doing a 'ldd /usr/bin/gluxconf' and make sure that gtk+ is the only depedency needed other than glibc. Your "compiled for me with this" comment leads me to believe that you are uncertain that this is the only dependency. 4. If there are README's, License, or other documentation included in the tarball, install them with a appropriate dodoc line in src_install. Hope this helps and thanks for the contribution. Created attachment 537 [details, diff]
revision to ebuild following Tod's comments
Not sure if a patch obsoletes the original ebuild?
nice job StuBear :) |