Bug 166205

Summary:	net-dialup/mgetty - Adds support for handhelds and usb phones that only create device nodes when initated from device
Product:	Gentoo Linux	Reporter:	Luke McKee <hojuruku>
Component:	Current packages	Assignee:	Gentoo Dialup Developers <net-dialup>
Status:	RESOLVED WONTFIX
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://win.mol.ru/penguin/linux-palm-m50x-usb-tricks.html
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch for latest mgetty to support palm and nodevsleep option how to use the patch in an ebuild (just added 3 lines)

Description Luke McKee 2007-02-10 14:26:00 UTC

I wanted to get mgetty working with my palm. See the referred website.
I patched the ebuild and up-ported the patch for mgetty 1.0. Please review. 

Tested with my Palm TE2 and it works great. You can also start a process that can handle hotsync or PPP and mgetty will automatically detect it.

Could you put this into mainstream? I made the ebuild use the "pda" use flag as this benefits any other kind of organiser / smart phone (the nodevsleep option to mgetty)



Reproducible: Always

Steps to Reproduce:
1. Apply my patches
2. Test :)
3. Let me give 10 more and then give me gentoo dev access :-)

Comment 1 Luke McKee 2007-02-10 14:27:17 UTC

Created attachment 109717 [details, diff]
Patch for latest mgetty to support palm and nodevsleep option

Comment 2 Luke McKee 2007-02-10 14:28:29 UTC

Created attachment 109718 [details]
how to use the patch in an ebuild (just added 3 lines)

Uses "pda" use flag to include patch. Lets leave it optional because it is new.

Tested ok and works with my Palm.

Comment 3 Alin Năstac (RETIRED) gentoo-dev

2007-03-18 08:28:38 UTC

At first glance, the patch looks OK to me, except for that exit() calls from within read_to_ring() and write_from_ring(). Since exit() isn't called when read()  or write() function fails, I don't see why it should be called when select() fails. Better let the caller do that.

Please try to contact upstream first and ask them if they can apply this patch (maybe without those exit() I told you about) to their tree. From what I see in the current changelog, Gert Doering is the current maintainer. If he refuses, remove those exits and re-attach it here. I will add the patch to the portage tree.

Comment 4 Alin Năstac (RETIRED) gentoo-dev

2007-10-04 06:36:38 UTC

ping

Comment 5 Alin Năstac (RETIRED) gentoo-dev

2007-11-05 10:49:37 UTC

The reporter vanished. Closed with WONTFIX.