Bug 162441 – [QA] app-office/scribus-1.3.3.7 has poor programming practices

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sandro Bonazzola (RETIRED) 2007-01-16 21:47:58 UTC]

* QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * scimage.cpp:378: warning: dereferencing type-punned pointer will break strict-aliasing rules
scimage.cpp:386: warning: dereferencing type-punned pointer will break strict-aliasing rules
scimage.cpp:393: warning: dereferencing type-punned pointer will break strict-aliasing rules
scimage.cpp:419: warning: dereferencing type-punned pointer will break strict-aliasing rules

[cut]

and a lot of other messages like these.

[Comment 1 Hanno Böck 2007-01-21 09:33:50 UTC]

Craig, can you have a look?

[Comment 2 Craig Bradney 2007-01-21 11:02:48 UTC]

Will sort for 1.3.3.8

[Comment 3 Craig Bradney 2007-01-23 20:07:04 UTC]

fixed for scimage.cpp in 1.3.3.8cvs. 

[Comment 4 Craig Bradney 2007-02-24 23:18:01 UTC]

.............
l-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -fno-builtin -g3 -fno-inline -march=prescott -O2 -pipe -Wall -fstrict-aliasing -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -g3 -fno-inline -O0  -Wno-non-virtual-dtor  -MT scimage.o -MD -MP -MF ".deps/scimage.Tpo" \
          -c -o scimage.o `test -f 'scimage.cpp' || echo './'`scimage.cpp; \
        then mv -f ".deps/scimage.Tpo" ".deps/scimage.Po"; \
        else rm -f ".deps/scimage.Tpo"; exit 1; \
        fi
/usr/qt/3/bin/moc ./scmenu.h -o scmenu.moc
if g++ -DHAVE_CONFIG_H -I. -I. -I..  -I/usr/include/libart-2.0
.............

All gone. 1.3.3.8 is out tonight/tomorrow.
Craig

[Comment 5 Hanno Böck 2007-02-25 18:42:59 UTC]

Craig, they're all gone for that file, but a bunch of other files have this warning, too.

scriptplugin.cpp:474: warning: dereferencing type-punned pointer will break strict-aliasing rules
cmddoc.cpp:153: warning: dereferencing type-punned pointer will break strict-aliasing rules
cmddoc.cpp:154: warning: dereferencing type-punned pointer will break strict-aliasing rules
cmddoc.cpp: In function 'PyObject* scribus_savedocas(PyObject*, PyObject*)':
cmddoc.cpp:179: warning: dereferencing type-punned pointer will break strict-aliasing rules
cmddoc.cpp:180: warning: dereferencing type-punned pointer will break strict-aliasing rules

and many more.

[Comment 6 Craig Bradney 2007-02-26 20:20:28 UTC]

Yes I know, however in all my googling, this relates to the way that Python is coded. See:
http://mail.python.org/pipermail/python-bugs-list/2003-July/018802.html
http://webcvs.cairographics.org/pycairo/configure.ac?revision=1.63&view=markup
etc etc
They basically turn off the warning that shows up this error, so there's nothing we can do about it if the build environment is going to force it on us.

IMO, unless you can find some proper code for Python, or a workaround for us, this bug is done, or perhaps, reopen it against Python.

We hope to rewrite Scripter with one of the many scripting options before Scribus 1.4 and hopefully this will go away then.

[Comment 7 Hanno Böck 2007-04-02 21:55:15 UTC]

Reporter, please advise cbradney if this is still an issue, else I consider this fixed.