| Summary: | dev-libs/g-wrap-1.9.7 missing dependency + missing keywords + patch for dev-libs/glib-2* | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Josh Sled <jsled> |
| Component: | New packages | Assignee: | Scheme Project <scheme> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jakub |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
configure.ac patch to configure against glib-2.0
dev-libs/g-wrap/g-wrap-1.9.7.ebuild g-wrap_glib-automagic.patch dev-libs/g-wrap/files/glib_automagic.patch AT_M4DIR="${S}/m4" eautoreconf dev-libs/g-wrap/g-wrap-1.9.7.ebuild dev-libs/g-wrap/files/glib_automagic.patch |
||
Created attachment 106798 [details, diff]
configure.ac patch to configure against glib-2.0
*g-wrap-1.9.7 (12 Jan 2007) 12 Jan 2007; Marijn Schouten hkBst@gentoo.org +g-wrap-1.9.7.ebuild: Added 1.9.7 ebuild Marijn, where have the keywords gone? You need to either keep them on version bump *or* file a re-keywording bug and CC arches if there was a serious reason to drop them (like unkeyworded new dependencies, major changes that need testing etc.) Don't do this again, please... Keywords for dev-libs/g-wrap: | a a a h i m m p p p s s s s x x | l m r p a 6 i p p p 3 h p p 8 8 | p d m p 6 8 p c c c 9 a a 6 6 | h 6 a 4 k s 6 - 0 r r - | a 4 4 m c c f | a - b | c f s | o b d | s s | d ---------+-------------------------------- 1.3.4-r1 | + + + + + + 1.9.7 | ~ added keywording request (bug 162010) Reassigning based on recent metadata changes I removed glib-1* from my system and remerged g-wrap-1.9.7. I guess since it is an optional dependency it doesn't find glib and emerges fine. How do you test whether g-wrap works with glib? Needs to be fixed... http://www.gentoo.org/proj/en/qa/automagic.xml Created attachment 107356 [details] dev-libs/g-wrap/g-wrap-1.9.7.ebuild This ebuild doesn't do any patching, but just eautoreconf. The configure produced isn't working though: >>> Compiling source in /var/tmp/portage/dev-libs/g-wrap-1.9.7/work/g-wrap-1.9.7 ... * econf: updating g-wrap-1.9.7/config.guess with /usr/share/gnuconfig/config.guess * econf: updating g-wrap-1.9.7/config.sub with /usr/share/gnuconfig/config.sub ./configure --prefix=/usr --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --without-glib --libdir=/usr/lib64 --build=x86_64-pc-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether to enable maintainer-specific portions of Makefiles... no ./configure: line 2470: syntax error near unexpected token `CORE,' ./configure: line 2470: `GW_RUNTIME_VINFO(CORE, 1, 0, 0)' Comment on attachment 106798 [details, diff] configure.ac patch to configure against glib-2.0 (In reply to comment #7) > This ebuild doesn't do any patching, but just eautoreconf. The configure > produced isn't working though: Why are you doing eautoreconf when you didn't change anything? I guess we should recycle the original patch, stick glib-2* into DEPEND unconditionally and be done with this until someone has more time. Created attachment 107368 [details, diff]
g-wrap_glib-automagic.patch
Here's a quick attempt on non-automagic approach, but we don't need glib to be optional, gnucash is the only thing using this and it already needs glib anyway.
I have a patch, but either with or without it eautoreconf messes up. The point of the ebuild is to clearly show that this is the case. So if the zero patch doesn't work, there is no possibility for any real patch to work. So I can't even depend on glib-2* because the configure process only looks for glib-1* and I can't change anything about the configure process in the right way without eautoreconf. *sighs* Created attachment 107377 [details, diff]
dev-libs/g-wrap/files/glib_automagic.patch
As eautoreconf seems to be working for jakub, I've attached my patch.
Created attachment 107381 [details]
AT_M4DIR="${S}/m4" eautoreconf
fixed ebuild
Created attachment 107383 [details]
dev-libs/g-wrap/g-wrap-1.9.7.ebuild
fixed ebuild
Created attachment 107385 [details]
dev-libs/g-wrap/files/glib_automagic.patch
working patch, finally :)
fixed in 1.9.7-r1 |
g-wrap-1.9.7 continues to (only) configure against glib-1.x. Most systems, especially moving forward, will only have glib-2.x. Luckily, g-wrap builds fine against glib-2.0 without modifications. Unfortunately, its configure{,.ac} doesn't look for glib-2.0, only glib[-1.0]. Thus, the idea of the patch in Bug#125468 <http://bugs.gentoo.org/attachment.cgi?id=81682> is still relevant, though the actual patch doesn't work anymore with g-wrap-1.9.7. I've attached a version for 1.9.7's configure.ac; `autoconf` needs to be run after it's applied, before configuring. Separately from the glib version, gnucash is the only package (in portage) that uses g-wrap, and it requires that g-wrap is built with glib support; it would be good if DEPEND reflected that requirement.