| Summary: | [prelink] make prelink print unresolved dependencies in detail | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Frank <mfrank> |
| Component: | [OLD] Core system | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | enhancement | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
please submit the patch here: http://bugzilla.redhat.com/bugzilla/ |
Prelink produces a cryptic error message "Could not find one of the dependencies" which the enclosed patch fixes. The issue popped up because revdep-rebuild is broken - see the next bug Reproducible: Always Steps to Reproduce: Delete a library file and run prelink -n -a Actual Results: /usr/bin/xchat-remote-2: Could not find one of the dependencies Expected Results: /usr/bin/xchat-remote-2: Could not find the dependency libdbus-1.so.2 Patch for sys-devel/prelink-20060712 Patch file: prelink-mhfp42 --- prelink/src/gather.c.orig 2007-01-07 16:22:19.000000000 +0100 +++ prelink/src/gather.c 2007-01-07 23:43:14.000000000 +0100 @@ -56,6 +56,20 @@ } *blacklist_ext; static int blacklist_next; +void depnotfound(const char* lib, const char* dep) +{ + char tbuf[64]; + char *p = tbuf, *d = (char *)dep; + int i; + + for (i = 0; *d != ':' && i < 63; i++) + *p++ = *d++; + + *p = '\0'; + + error (0, 0, "%s: Could not find the dependency %s",lib,tbuf); +} + static int gather_deps (DSO *dso, struct prelink_entry *ent) { @@ -183,8 +197,7 @@ q = strstr (p, " ("); if (q == NULL && strcmp (p, " => not found") == 0) { - error (0, 0, "%s: Could not find one of the dependencies", - ent->filename); + depnotfound(ent->filename,p); goto error_out; } } @@ -202,9 +215,7 @@ "No such file or directory"); if (q != NULL) { - error (0, 0, - "%s: Could not find one of the dependencies", - ent->filename); + depnotfound(ent->filename,p); goto error_out; } }