Bug 160575

Summary:	media-sound/audacious: crash, infinite loop (100% CPU) because of an erroneous playlist
Product:	Gentoo Linux	Reporter:	Raphael Marichez (Falco) (RETIRED) <falco>
Component:	Current packages	Assignee:	Tony Vroon (RETIRED) <chainsaw>
Status:	RESOLVED FIXED
Severity:	minor	CC:	dhp_gentoo, security
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Upstream backport another proposal

Description Raphael Marichez (Falco) (RETIRED) gentoo-dev

2007-01-06 21:09:26 UTC

Hi,

i've found why audacious takes 100% CPU, doesn't respond, and needs a "kill", when the last item of the playlist is not playable (access denied, not an audio file, maybe other reasons).
Each loop calls many open() syscalls which heavy in some cases.

The future 1.3 branch is fixed upstream but our 1.2.2 ebuild needs a fix.

i propose two patches, the first being a backport from upstream 1.3-alpha (but now fixed, it was initially incorrect), and the second is an adaptation from the first one, which will catch all potential pathological cases imho.

Comment 1 Raphael Marichez (Falco) (RETIRED) gentoo-dev

2007-01-06 21:11:06 UTC

Created attachment 105707 [details, diff]
Upstream backport

Comment 2 Raphael Marichez (Falco) (RETIRED) gentoo-dev

2007-01-06 21:11:33 UTC

Created attachment 105709 [details, diff]
another proposal

Comment 3 Raphael Marichez (Falco) (RETIRED) gentoo-dev

2007-01-06 21:35:25 UTC

Finally upstream has chosen to switch to the second patch (with "for(penalty...)" )

Comment 4 DEMAINE Benoît-Pierre, aka DoubleHP 2007-03-01 12:49:09 UTC

For which audacious did you report ? if your patch have been emrged, is new ebuild available ? if yes, please close !

Comment 5 William Pitcock 2007-03-01 14:08:17 UTC

1.3 solves this issue. For the most part, this can be closed.

Comment 6 Raphael Marichez (Falco) (RETIRED) gentoo-dev

2007-03-01 14:14:06 UTC

yes sure, upstream has fixed it and incorporated my proposal in 1.3-alpha-something, so in media-sound/audacious-1.3.0-rc2 which is not in the stable tree yet, but maybe on its way.