Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 160234

Summary: misc-functions.sh 'poor programming practices' check is slow due to grep sucking in unicode locales
Product: Portage Development Reporter: Jakub Moc (RETIRED) <jakub>
Component: Core - External InteractionAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS
Priority: High    
Version: 2.1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 835380, 147007    

Description Jakub Moc (RETIRED) gentoo-dev 2007-01-05 04:34:23 UTC
Please, either grep the logfiles for the gcc warnings w/ FEATURES="stricter" only, or force LC_ALL=C for grep. 

grep performance sucks big time w/ UTF-8 locales (Bug 93443) and this checks takes over a minute on large log files (~1MB+) here.
Comment 1 solar (RETIRED) gentoo-dev 2007-01-05 14:36:26 UTC
Where are you saying there is poor programming practices?
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-01-05 14:39:20 UTC
(In reply to comment #1)
> Where are you saying there is poor programming practices?

Huh? I'm not; I don't even care, just nuke or tweak the check to not waste time. I guess you've misunderstood what I'm saying here, 'poor programming practices' is what the check spits out, not me...


Comment 3 SpanKY gentoo-dev 2007-01-05 17:37:06 UTC
you sure do like to whine ... upgrade your computer to a quad core, that'll make it run faster i bet
Comment 4 Alec Warner (RETIRED) archtester gentoo-dev Security 2007-01-07 03:50:06 UTC
Or just make install_qa_checks optional ;)

*runs*
Comment 5 Zac Medico gentoo-dev 2007-01-07 20:14:58 UTC
This has been released in 2.1.2_rc4-r7.