Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 160025

Summary: media-libs/libgpod : broken autotools handling (cleanup ebuilds please)
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Olivier Crete (RETIRED) <tester>
Status: VERIFIED FIXED    
Severity: major CC: ed, gerdlc, jathey, joem, karl, swapon, tgurr
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 148821    
Attachments: libgpod-use-eautoreconf.patch
emerge info

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2007-01-04 10:27:37 UTC
The following ebuilds are found to have broken autotools handling, as they run libtoolize directly (they never should, instead they should call eautoreconf in autotools.eclass, read http://www.gentoo.org/proj/en/qa/autofailure.xml for more information):

./media-libs/libgpod/libgpod-0.3.0.ebuild:      libtoolize --force --copy
./media-libs/libgpod/libgpod-0.3.2-r1.ebuild:   libtoolize --force --copy

Please cleanup the ebuilds by asking for stable marking, removing obsolete ebuilds with no relevant keywords, or porting the fixes in newer versions (if presents) to properly handle autotools.

Thanks,
Diego
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-01-10 07:42:11 UTC
*** Bug 161248 has been marked as a duplicate of this bug. ***
Comment 2 Ed Catmur 2007-01-10 10:56:26 UTC
(From bug 161248)
Also, libgpod-0.4.0.ebuild is broken:
* unversioned depends on sys-devel/autoconf, sys-devel/automake
* depends on intltool (why? it ships the intltool-*.in files)
* runs eauto* functions individually
Comment 3 Ed Catmur 2007-01-10 11:01:11 UTC
Created attachment 106336 [details, diff]
libgpod-use-eautoreconf.patch

Patch as above.
Comment 4 Karl H 2007-01-13 11:41:02 UTC
libgpod-use-eautoreconf.patch did not work for me


>> Unpacking libgpod-0.4.0.tar.gz to /var/tmp/portage/libgpod-0.4.0/work
 * Applying libgpod-0.4.0-test-nogdk.patch ...                                                                                         [ ok ]
 * Running eautoreconf in '/var/tmp/portage/libgpod-0.4.0/work/libgpod-0.4.0' ...
 * Requested autoconf 2.5
 * Using autoconf (GNU Autoconf) 2.61
 * Using autoheader (GNU Autoconf) 2.61
 * Requested automake latest: 1.10
 * Using automake (GNU automake) 1.10
 * Using aclocal (GNU automake) 1.10
 * Running aclocal -I m4 ...                                                                                                           [ ok ]
 * Running libtoolize --copy --force --automake ...                                                                                    [ ok ]
 * Running aclocal -I m4 ...                                                                                                           [ ok ]
 * Running autoconf ...                                                                                                                [ ok ]
 * Running autoheader ...                                                                                                              [ ok ]
 * Running automake --add-missing --copy ...                                                                                           [ !! ]

 * Failed Running automake !
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/libgpod-0.4.0/temp/automake-9069.out


!!! ERROR: media-libs/libgpod-0.4.0 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_unpack
  ebuild.sh, line 708:   Called src_unpack
  libgpod-0.4.0.ebuild, line 33:   Called eautoreconf
  autotools.eclass, line 94:   Called eautomake
  autotools.eclass, line 195:   Called autotools_run_tool 'automake' '--add-missing' '--copy'
  autotools.eclass, line 256:   Called die

!!! Failed Running automake !
!!! If you need support, post the topmost build error, and the call stack if relevant.

!!! This ebuild is from an overlay: '/usr/local/portage'



cat /var/tmp/portage/libgpod-0.4.0/temp/automake-9069.out
***** automake *****

gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
gtk-doc.make:43: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
gtk-doc.make:136: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
tests/Makefile.am:38: compiling `test-photos.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac'
Comment 5 Ed Catmur 2007-01-13 14:00:54 UTC
Are you on stable?  Try installing dev-util/gtk-doc-1.7.
Comment 6 Joseph Dunnigan 2007-01-13 17:57:36 UTC
(In reply to comment #5)
> Are you on stable?  Try installing dev-util/gtk-doc-1.7.
> 

The problem here was that gtk-doc was not installed. Installing stable dev-util/gtk-doc-1.6-r1 allowed libgpod to install (using patched ebuild). libgpod was installing fine before the gtk use flag was turned on.
Comment 7 Olivier Crete (RETIRED) gentoo-dev 2007-01-13 18:12:25 UTC
ok, I'll add a dep on gtk-doc if the gtk flag is set..  and the autotools patch is in. Thanks to you all.
Comment 8 Alessio Cassibba (X-Drum) 2007-01-14 14:58:00 UTC
hi, still have problems with media-libs/libgpod-0.4.0 on AMD64:

emerge -uDNav world
[ebuild   R   ] media-libs/libgpod-0.4.0  USE="python -gtk*" 0 kB

>>> Emerging (1 of 1) media-libs/libgpod-0.4.0 to /
 * libgpod-0.4.0.tar.gz MD5 ;-) ...                                                                                                                    [ ok ]
 * libgpod-0.4.0.tar.gz RMD160 ;-) ...                                                                                                                 [ ok ]
 * libgpod-0.4.0.tar.gz SHA1 ;-) ...                                                                                                                   [ ok ]
 * libgpod-0.4.0.tar.gz SHA256 ;-) ...                                                                                                                 [ ok ]
 * libgpod-0.4.0.tar.gz size ;-) ...                                                                                                                   [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                   [ ok ]
 * checking auxfile checksums ;-) ...                                                                                                                  [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                 [ ok ]
 * checking libgpod-0.4.0.tar.gz ;-) ...                                                                                                               [ ok ]
>>> Unpacking source...
>>> Unpacking libgpod-0.4.0.tar.gz to /var/tmp/portage/libgpod-0.4.0/work
 * Applying libgpod-0.4.0-test-nogdk.patch ...                                                                                                         [ ok ]
 * Running eautoreconf in '/var/tmp/portage/libgpod-0.4.0/work/libgpod-0.4.0' ...
 * Requested autoconf 2.5
 * Using autoconf (GNU Autoconf) 2.61
 * Using autoheader (GNU Autoconf) 2.61
 * Requested automake latest: 1.10
 * Using automake (GNU automake) 1.10
 * Using aclocal (GNU automake) 1.10
 * Running aclocal -I m4 ...                                                                                                                           [ ok ]
 * Running libtoolize --copy --force --automake ...                                                                                                    [ ok ]
 * Running aclocal -I m4 ...                                                                                                                           [ ok ]
 * Running autoconf ...                                                                                                                                [ ok ]
 * Running autoheader ...                                                                                                                              [ ok ]
 * Running automake --add-missing --copy ...                                                                                                           [ !! ]

 * Failed Running automake !
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/libgpod-0.4.0/temp/automake-1274.out


!!! ERROR: media-libs/libgpod-0.4.0 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_unpack
  ebuild.sh, line 708:   Called src_unpack
  libgpod-0.4.0.ebuild, line 34:   Called eautoreconf
  autotools.eclass, line 94:   Called eautomake
  autotools.eclass, line 195:   Called autotools_run_tool 'automake' '--add-missing' '--copy'
  autotools.eclass, line 256:   Called die

!!! Failed Running automake !
!!! If you need support, post the topmost build error, and the call stack if relevant.

/var/tmp/portage/libgpod-0.4.0/temp/automake-1274.out:
***** automake *****

gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
gtk-doc.make:43: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
gtk-doc.make:136: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/Makefile.am:74:   `gtk-doc.make' included from here
tests/Makefile.am:38: compiling `test-photos.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac'
Comment 9 Alessio Cassibba (X-Drum) 2007-01-14 14:59:01 UTC
Created attachment 106942 [details]
emerge info

my emerge --info
Comment 10 Olivier Crete (RETIRED) gentoo-dev 2007-01-14 16:42:13 UTC
do you have gtk-doc installed ?
Comment 11 Alessio Cassibba (X-Drum) 2007-01-14 18:39:34 UTC
(In reply to comment #10)
> do you have gtk-doc installed ?
> 

no i don't, i'm emerging media-libs/libgpod-0.4.0
with USE="python -gtk"
Comment 12 Olivier Crete (RETIRED) gentoo-dev 2007-01-15 00:12:40 UTC
oops, gtk-doc wasn't supposed to be optional. otherwise the eautoreconf doesnt work (and the doc isnt built)..
Comment 13 Alessio Cassibba (X-Drum) 2007-01-15 12:40:25 UTC
(In reply to comment #12)
> oops, gtk-doc wasn't supposed to be optional. otherwise the eautoreconf doesnt
> work (and the doc isnt built)..
> 

i did an emerge --sync today, now emerge shows gtk-doc as dep of libgpod.
All fine now thx
Comment 14 Timo Gurr (RETIRED) gentoo-dev 2007-01-17 23:05:57 UTC
Is there any way to not install the docs? The dependencies are quite heavy and unneccessary in my opinion, and since I had libgpod-0.4.0 installed before without those dependencies it *should* be possible, perhaps a doc USE flag?

[ebuild  N    ] app-text/opensp-1.5.2-r1  USE="nls -doc" 1,486 kB
[ebuild  N    ] app-text/docbook-sgml-dtd-3.0-r3  43 kB
[ebuild  N    ] app-text/scrollkeeper-0.3.14-r2  USE="nls" 664 kB
[ebuild  N    ] app-text/docbook-dsssl-stylesheets-1.79  272 kB
[ebuild  N    ] app-text/openjade-1.3.2-r1  874 kB
[ebuild  N    ] dev-util/gtk-doc-1.7  USE="-debug -doc -emacs" 176 kB
[ebuild   R   ] media-libs/libgpod-0.4.0  USE="-gtk* -python" 0 kB

Please correct me if I'm wrong here. I'd rather have those gtk related things not installed on a KDE system.
Comment 15 Olivier Crete (RETIRED) gentoo-dev 2007-01-17 23:16:37 UTC
Hopefully we will be able to do that in the next version. In the current version, we have to run eautoreconf and that requires gtk-doc to be installed (otherwise we'd have to depend on all of GTK+). 
Comment 16 Ed Catmur 2007-01-17 23:28:46 UTC
It might be possible to just ship gtk-doc.m4 and stick it in ${S}/m4; it's only 1525 bytes so it could go in the tree.  Indeed, the package is at fault for not shipping it.
Comment 17 Olivier Crete (RETIRED) gentoo-dev 2007-01-18 20:17:48 UTC
for those who care, libgpod 0.4.2 is out and the doc flag should disable the gtk-doc dep.. But if you have libgpod compiled without the gtk use flag, you dont get album artwork. Can you also check that this new version works correctly with amarok? gtkpod needed a patch.
Comment 18 Alessio Cassibba (X-Drum) 2007-01-18 23:46:09 UTC
(In reply to comment #17)
> for those who care, libgpod 0.4.2 is out and the doc flag should disable the
> gtk-doc dep.. But if you have libgpod compiled without the gtk use flag, you
> dont get album artwork. Can you also check that this new version works
> correctly with amarok? gtkpod needed a patch.
> 
hi, media-sound/amarok-1.4.4-r3 with USE ipod fails to build
with media-libs/libgpod-0.4.2 (USE="-doc gtk" or USE="-doc -gtk" )

http://bugs.gentoo.org/show_bug.cgi?id=162725

Comment 19 Alessio Cassibba (X-Drum) 2007-01-19 02:18:37 UTC
(In reply to comment #17)
Can you also check that this new version works
> correctly with amarok? gtkpod needed a patch.
> 
thanks to bug #160025 i was able to test media-libs/libgpod-0.4.2 with media-sound/amarok-1.4.4-r3, the result is the same:
when media-libs/libgpod is compiled with USE="-gtk" the album artwork is
not uploaded on the ipod.

(In reply to comment #14)
> Is there any way to not install the docs? The dependencies are quite heavy and
> unneccessary in my opinion,
but thanks to the doc USE now there are less dependencies (for kde users)