Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 159262

Summary: saveas USE for x11-libs/GTK+
Product: Gentoo Linux Reporter: Shem Valentine <bugzilla>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: VERIFIED LATER    
Severity: enhancement    
Priority: High    
Version: 2006.1   
Hardware: All   
OS: Linux   
URL: http://gentoo-wiki.com/HOWTO_Beautify_GNOME#Save_dialogs_expanded_by_default
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: save as patch

Description Shem Valentine 2006-12-27 21:47:09 UTC
I would like to request the expanded save as dialog patch as a use flag for x11-libs/gtk+  It is a feature that has many times been reported to the gnome bugzilla, but they continue to deny the users requests.  It is a rather simple patch.

Some references:
http://gentoo-wiki.com/HOWTO_Beautify_GNOME#Save_dialogs_expanded_by_default
http://forums.gentoo.org/viewtopic-t-362497-highlight-gtk+save+dialog+patch.html

The patch (works as of 2.10.6)

--- orig/gtk/gtkfilechooserdefault.c	27 Jan 2006 17:22:17 -0000	1.312
+++ new/gtk/gtkfilechooserdefault.c	15 Feb 2006 18:55:46 -0000
@@ -3984,11 +3984,13 @@ save_widgets_create (GtkFileChooserDefau
   gtk_box_pack_start (GTK_BOX (vbox), alignment, FALSE, FALSE, 0);
 
   impl->save_expander = gtk_expander_new_with_mnemonic (_("_Browse for other folders"));
+  gtk_expander_set_expanded (GTK_EXPANDER (impl->save_expander),TRUE);
   gtk_container_add (GTK_CONTAINER (alignment), impl->save_expander);
   g_signal_connect (impl->save_expander, "notify::expanded",
 		    G_CALLBACK (expander_changed_cb),
 		    impl);
   gtk_widget_show_all (alignment);
+  gtk_widget_hide (impl->save_expander);
 
   impl->save_widgets = vbox;
   gtk_box_pack_start (GTK_BOX (impl), impl->save_widgets, FALSE, FALSE, 0);
Comment 1 Shem Valentine 2006-12-27 21:53:31 UTC
*** Bug 159263 has been marked as a duplicate of this bug. ***
Comment 2 Shem Valentine 2006-12-27 21:53:52 UTC
*** Bug 159264 has been marked as a duplicate of this bug. ***
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-12-27 22:35:51 UTC
*** Bug 159265 has been marked as a duplicate of this bug. ***
Comment 4 Shem Valentine 2006-12-27 22:48:09 UTC
Created attachment 104834 [details, diff]
save as patch

Most up to date but still only works for open dialog as of 2.10
Comment 5 Shem Valentine 2006-12-27 22:53:48 UTC
I sure have made a muck of this bug, my apologies.  The posted patch is more proper to 2.10.6, but both only affect the open dialog.  Since the change to 2.10 these patches do not seem to effect the save as dialog as well.

I am not a programmer so I don't know how to fix these now broken patches.  I will close this bug.

I will try to get in contact with the guy that wrote the original patch that I derived these from.  If this is an enhancement that may be considered I will return with the proper patch... or perhaps one of you brilliant gentleman can figure it out ;)
Comment 6 Shem Valentine 2006-12-27 23:07:46 UTC
screw it, I've had enough of gnome, I'm moving to kde