Bug 158663

Summary:	mail-client/sylpheed-2.3.0rc version bump
Product:	Gentoo Linux	Reporter:	Milan Holzäpfel <mail>
Component:	New packages	Assignee:	Akinori Hattori <hattya>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	net-mail+disabled
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://sylpheed.sraoss.jp/en/news.html
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Diff from sylpheed-2.2.10.ebuild to sylpheed-2.3.10.ebuild Patch for sylpheed 2.3 to replace aspell with enchant.

Description Milan Holzäpfel 2006-12-20 10:01:05 UTC

Hello, 

as Sylpheed 2.3.0 final is scheduled for 24 December according to its maintainer, it might make sense to add an ebuild for the yesterday-released version 2.3.0rc. 

I will attach a patch with the changes I made. These are only related to the naming of the tarball though. Feel free to improve them if needed. 

Regards,
Milan

Comment 1 Milan Holzäpfel 2006-12-20 10:04:21 UTC

Created attachment 104449 [details, diff]
Diff from sylpheed-2.2.10.ebuild to sylpheed-2.3.10.ebuild

Comment 2 Andrej Kacian (RETIRED) gentoo-dev

2006-12-20 23:00:05 UTC

I can't see why it might make sense to add an ebuild for a release candidate. If you want to help upstream with testing, just bump it in a local overlay and off you go.

Akinori, your call.

Comment 3 Milan Holzäpfel 2006-12-23 10:29:16 UTC

Ok. 

Today, Sylpheed 2.3.0 has been released.

For sylpheed 2.3.0 copying sylpheed-2.2.10.ebuild to sylpheed-2.3.0.ebuild is enough.  (Tested successfully on x86 (hardened) and amd64.)

Regards,
Milan

Comment 4 Dale Whittaker 2006-12-24 05:53:35 UTC

Created attachment 104680 [details, diff]
Patch for sylpheed 2.3 to replace aspell with enchant.

I think that the aspell/enchant patch needs to be updated for the gtkspell use flag to be working correctly.  I have attached an updated patch for 2.3 (based on the old one) which appears to work for me.

Thanks,

Dale

Comment 5 Akinori Hattori gentoo-dev

2006-12-24 06:38:14 UTC

(In reply to comment #4)
> Patch for sylpheed 2.3 to replace aspell with enchant.
> 
It is not necessary to attach a patch which changed only the indent style.
(The patch for 2.2 series can be applied for 2.3.0 as well)

> I think that the aspell/enchant patch needs to be updated for the gtkspell use
> flag to be working correctly.  I have attached an updated patch for 2.3 (based
> on the old one) which appears to work for me.
> 
Why? Did you read the compose.c or the patch?
It changes the behavior of Sylpheed *only* when --enable-gtkspell is passed to configure.
(All changes are inside of "#ifdef USE_GTKSPELL")

Comment 6 Akinori Hattori gentoo-dev

2006-12-24 06:44:26 UTC

Fixed in CVS. Thank you for reporting!