Bug 158588 – net-fs/openafs-1.4.2 client init script not returning correct return code when stopping

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Volkmar Glauche 2006-12-19 14:15:01 UTC]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1) Gecko/20061215 BonEcho/2.0
Build Identifier: 

The stop() function does not explicitly return zero when stopping the client was
successful. This prevents a clean restart of openafs-client, if the last rmdir
command returns non-zero status.

Reproducible: Always

Steps to Reproduce:
1./etc/init.d/openafs-client start
2./etc/init.d/openafs-client stop
3./etc/init.d/openafs-client start

Actual Results:  
On the second start, the init script claims that the service is still running.
This is not true.


Portage 2.1.2_rc3-r4 (default-linux/amd64/2006.1, gcc-4.1.1, glibc-2.5-r0,
2.6.19-gentoo-r1 x86_
64)
=================================================================
System uname: 2.6.19-gentoo-r1 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
Gentoo Base System version 1.12.7
Last Sync: Thu, 14 Dec 2006 01:47:01 +0000
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.4
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=athlon64"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-re
build /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distcc distlocks metadata-transfer
sandbox sfperms strict
"
GENTOO_MIRRORS="ftp://ftp.rz.ruhr-uni-bochum.de/gentoo-mirror/
ftp://distfiles.gentoo.org ftp://
ftp.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-
file --delete --delete-after --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclu
de=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="amd64 X Xaw3d a52 aac aalib acl acpi adns alsa ao arts audiofile
bash-completion bcmath ber
kdb bindist bitmap-fonts blas bonobo bzip2 cairo calendar caps cdparanoia cdr
clamav cli crackli
b crypt cscope ctype cups curl curlwrappers dba dbase dbm dbus dga dio dlloader
doc dri dts dv d
vb dvd dvdr dvdread eds elibc_glibc emacs emacs-w3 emboss encode esd evo exif
expat fam fbcon ff
mpeg fftw firebird firefox flac flash flatfile fltk fortran ftp gb gcj gd gdbm
geoip ggi gif gin
ac glut gmp gnome gnustep gnutls gphoto2 gpm graphviz gstreamer gtk gtk2 gtkhtml
guile hal harde
ned hardenedphp howl iconv idn ieee1394 imagemagick imap imlib inifile
input_devices_evdev input
_devices_keyboard input_devices_mouse ipod ipv6 isdnlog java javascript jbig
jikes jpeg jpeg2k k
de kerberos kernel_linux krb4 ladcca ladspa lapack lash lcms ldap leim libcaca
libedit libg++ li
bgda libnotify libsamplerate libwww lirc lm_sensors lua m17n-lib mad maildir
mailwrapper matrosk
a mbox mcal memlimit mhash migemo mikmod mime ming mmap mng mnogosearch mono
motif mozilla mp3 m
peg mplayer msession mule musepack nas ncurses neXt netboot netcdf nls nntp nptl
nptlonly nsplug
in offensive ogg openal openexr opengl pam pcntl pcre pda pdf perl php plotutils
png portaudio p
osix ppds pppd prelude profile python qt3 qt4 quicktime rdesktop readline recode
reflection ruby
 sasl scanner sdl session sharedext sharedmem shorten simplexml skey slang slp
smartcard sndfile
 soap sockets sox speex spell spl sqlite sqlite3 ssl startup-notification svg
symlink sysvipc sz
ip tcl tcltk tcpd tetex theora threads tidy tiff tk tokenizer truetype
truetype-fonts type1-font
s udev unicode usb userland_GNU vcd verbose video_cards_dummy video_cards_fbdev
video_cards_nv v
ideo_cards_vesa video_cards_vga video_cards_vmware vim-syntax vorbis wmf
wxwindows xine xinetd x
ml xmlrpc xorg xpm xprint xsl xv xvid zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
LINGUAS, PORTAGE_RSYN
C_EXTRA_OPTS, PORTDIR_OVERLAY

[Comment 1 Volkmar Glauche 2006-12-19 14:20:56 UTC]

Created attachment 104395 [details, diff]
Explicitly add a return code of zero if we have gone past removing /afs.

[Comment 2 Stefaan De Roeck (RETIRED) 2006-12-23 01:27:29 UTC]

Fixed in openafs-1.4.3_pre20061220.  Thanks a lot for reporting, and for providing a patch!!