Summary: | sys-fs/udev-103 network device renaming fails occasionally | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Gerte Hoogewerf <g.hoogewerf> |
Component: | [OLD] Core system | Assignee: | udev maintainers <udev-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | base-system |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Gerte Hoogewerf
2006-12-19 04:13:51 UTC
I have found something that in my opinion is incorrect and perhaps causing some problems. In udev_device.c, function rename_netif we enter a busy wait loop. If you take a close look to the way we can leave this loop there are two ways: * With an errno != EEXIST * When loop == 0 The first one should really never happen. The second should happen only if a network interface name does not come available during our polling, so only when we want to timeout the polling. Try to imagine what happens if the ioctl succeeds.... We just re-enter the loop and now something will go wrong. Feel free to use this patch to correct it: http://gerte.nietbelangrijk.nl/udev-103-busywait.txt I think this is enough to kill the bug. But I'll be testing some more. I've tested udev with my patch. I have no issues anymore. What about inclusion, has anyone looked at it? For me the problem does not occur, renaming network interfaces works. This patch does no harm to me, after applying it, still everything works. forwarded to hotplug/udev-Mailinglist. Added patch to udev-104-r2 ebuild. Patch also got applied upstream. Thnx for forwarding the patch. The new ebuild makes me happy. |