Summary: | x86 stable request sys-fs/cowloop-3.0-r1 was: fails to compile on 2.6.19 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Willard Dawson <willard.dawson> |
Component: | Current packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | 2006.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 156669 |
Description
Willard Dawson
2006-12-18 08:13:17 UTC
*** Bug 158465 has been marked as a duplicate of this bug. *** thanks Willard. Resync and try again. Fixed in cowloop-3.0. Also reported upstream. Reopening as this is not fixed in the stable tree Willard can you confirm cowloop-3.0-r1 is working for you? As per comment #3 I assume Daniel will want this stable soon. Cowloop compiles to completion with only one incidental warning on my system. Otherwise, I'd say the compilation is stable. Here's the warning for reference:
i686-pc-linux-gnu-gcc -march=i686 -O2 -pipe -I. -Wall -o cowpack cowpack.c -lz
cowpack.c: In function `falperror':
cowpack.c:606: warning: 'gzerr' might be used uninitialized in this function
>>> Source compiled.
Daniel, please go ahead and get this marked stable asap Thanks for the feedback Willard. Test Plan: (derived from man cowloop) Here hda1 is readonly and mapped to /dev/cow0. Changes are stored in /tmp/cowtest. 0. Emerge cowloop-3.0-r1 with a 2.6.19 kernel 1 - load # modprobe cowloop rdofile=/dev/hda1 cowfile=/tmp/cowtest Check dmesg: should see: cowloop - (C) 2006 AT Consultancy/AT Computing cowloop - version: 3.0 cowloop - info: www.ATConsultancy.nl/cowloop cowloop - maximum allowed cowdevices: 16 cowloop - initialized on rdofile=/dev/hda # mount -o ro /dev/hda1 /boot # mount /dev/cow0 /mnt/test test 2: - read access # find /mnt/test (should show boot partition (if this is /dev/hda1) test 3: - write only writes to cowloop # cp /bin/ls /mnt/test # ls -la /boot/ls /mnt/test/ls Expected output - only writes to cowmount. ls: cannot access /boot/ls: No such file or directory -rwxr-xr-x 1 root root 103384 Dec 31 08:48 /mnt/test/ls 4. delete only delete's from cowloop # rm /mnt/test/System.map # ls -la /boot/System.map /mnt/test/System.map ls: cannot access /mnt/test/System.map: No such file or directory lrwxrwxrwx 1 root root 27 Dec 31 07:38 /boot/System.map -> System.map-2.6.19-gentoo-r1 5. delete directories only from cowloop # rm -rf /mnt/test/grub/ # ls -lad /mnt/test/grub /boot/grub/ ls: cannot access /mnt/test/grub: No such file or directory drwxr-xr-x 2 root root 1024 Dec 31 2006 /boot/grub/ 6. state preservation # umount /mnt/test # rmmod cowloop # modprobe cowloop rdofile=/dev/hda1 cowfile=/tmp/cowtest # ls -lad /mnt/test/grub /boot/grub/ ls: cannot access /mnt/test/grub: No such file or directory drwxr-xr-x 2 root root 1024 Dec 31 2006 /boot/grub/ # ls -la /boot/System.map /mnt/test/System.map ls: cannot access /mnt/test/System.map: No such file or directory lrwxrwxrwx 1 root root 27 Dec 31 07:38 /boot/System.map -> System.map-2.6.19-gentoo-r1 7. detects state change in ro file # umount /mnt/test # rmmod cowloop # umount /boot # mount -o rw /dev/hda1 /boot # modprobe cowloop rdofile=/dev/hda1 cowfile=/tmp/cowtest FATAL: Error inserting cowloop (/lib/modules/2.6.19-gentoo-r1/fs/cowloop.ko): Invalid argument # dmesg | tail cowfile /tmp/cowtest not related to rdofile (fingerprint err - rdofile modified?) Note: EXPECTED FAILURE as a rw mount modifies the partition 7. Userspace utils test # rm /tmp/cowtest # mount -o remount,ro /boot # modprobe cowloop rdofile=/dev/hda1 cowfile=/tmp/cowtest # cowwatch /dev/cow0 Total: 47777380 Kb Avail: 2601128 Kb # cowlist /tmp/cowtest Info about cowfile /tmp/cowtest: state cowfile: clean header-version: 1 data offset: 8192 mapunit: 1024 bitmap-blocks: 6 (of 1024 bytes) cowblocks in use: 0 (of 1024 bytes) size rdofile: 48163 (of 1024 bytes) # mount /dev/cow0 /mnt/test # cowlist /tmp/cowtest Info about cowfile /tmp/cowtest: state cowfile: dirty header-version: 1 data offset: 8192 mapunit: 1024 bitmap-blocks: 6 (of 1024 bytes) cowblocks in use: 0 (of 1024 bytes) size rdofile: 48163 (of 1024 bytes) Note state gone to dirty # cp /bin/dd /mnt/test/ # cp /bin/ls /mnt/test/ # cowsync # cowlist /tmp/cowtest Info about cowfile /tmp/cowtest: state cowfile: clean header-version: 1 data offset: 8192 mapunit: 1024 bitmap-blocks: 6 (of 1024 bytes) cowblocks in use: 163 (of 1024 bytes) size rdofile: 48163 (of 1024 bytes) Note some cowblocks used. 8. Optionally test with <=2.6.18 as the kernel stat api has changed. Moooo! x86 stable and closing. |