Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 158324

Summary: openssl-0.9.8d GCC 4.2 patch
Product: Gentoo Linux Reporter: Ryan Hill (RETIRED) <rhill>
Component: [OLD] Core systemAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED LATER    
Severity: normal CC: arfrever, esigra, gerbilsoft, jakub, loki_val, sadam31300
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 162167    
Attachments: openssl-0.9.8d-gcc42.patch
openssl-0.9.8e-gcc42.patch

Description Ryan Hill (RETIRED) gentoo-dev 2006-12-16 14:58:45 UTC
GCC 4.2 introduces strict enforcement preventing direct function pointer conversions between incompatible types by generating a runtime abort[i].  This does a great job of breaking openssl[ii].

This patch allows openssl to build and work, but is a temporary fix until things are decided upstream[iii].

GCC 4.2 also breaks building with -g* in CFLAGS, but that's another bug.

[i] http://gcc.gnu.org/ml/gcc/2006-07/msg00037.html
[ii] http://www.mail-archive.com/openssl-dev@openssl.org/msg21938.html
[iii] http://www.mail-archive.com/openssl-dev@openssl.org/msg21945.html
Comment 1 Ryan Hill (RETIRED) gentoo-dev 2006-12-16 14:59:32 UTC
Created attachment 104173 [details, diff]
openssl-0.9.8d-gcc42.patch
Comment 2 SpanKY gentoo-dev 2006-12-16 16:09:40 UTC
bug me when something actually gets merged upstream ... i'm not terribly warm to the idea of maintaining a patch in something like openssl that is full of hacks (by design) when it hasnt been accepted in the upstream repo, especially when the only benefiter here are gcc-4.2 users

so when it hits openssl's CVS, re-open the bug with that patch and i'll happily merge it
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2006-12-16 16:49:23 UTC
good call, it looks like they're going another way.
http://cvs.openssl.org/chngview?cn=15660
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2006-12-22 12:11:15 UTC
Comment on attachment 104173 [details, diff]
openssl-0.9.8d-gcc42.patch

this breaks kdelibs.
Comment 5 genbug 2007-01-30 15:51:54 UTC
that link refers to a patch from 0.9.8e to 0.9.9 , portage seems still at 8d.

Since this seems to have been dealt with upstream is this what you were waiting for fix this bug?

?(later==now)

thx.
Comment 6 genbug 2007-02-01 23:41:01 UTC
ftp://ftp.openssl.org/snapshot/openssl-0.9.8-stable-SNAP-20070201.tar.gz

a hacky bit of renaming and I build this release and it fixed the invalid conversion void (*) stuff . 

I was able to emerge lftp and htdig that where failing before on a 4.2 build system.

would be good to have a 4.2/4.3 usable ebuild in the tree.

Comment 7 SpanKY gentoo-dev 2007-02-02 01:44:28 UTC
we're not putting snapshots in the tree anymore, use the overlay
Comment 8 Ryan Hill (RETIRED) gentoo-dev 2007-02-02 22:59:32 UTC
(In reply to comment #5)
> Since this seems to have been dealt with upstream is this what you were waiting
> for fix this bug?
> 
> ?(later==now)

i was under the impression that wouldn't be the final solution and wanted to wait until there was one.  plus i've just been busy with other stuff.
Comment 9 Anonymous 2007-03-09 13:40:43 UTC
I have this problem on macos, with gcc-4.1.2. It's so weird that I have this problem, but this patch fixes it. Might consider adding it.
Comment 10 SpanKY gentoo-dev 2007-03-09 15:56:17 UTC
it isnt weird if you reviewed the full history of the bug ... the patch is not what went into upstream thus it's not going into Gentoo
Comment 11 Anonymous 2007-03-09 15:57:10 UTC
It's weird that I have a problem with gcc-4.1.2 that is supposed to happen for gcc-4.2 and higher.
Comment 12 SpanKY gentoo-dev 2007-03-09 19:51:34 UTC
so if i hadnt misread your comment then it'd make more sense ;)

i dont think it's that weird to be honest ... the OS X gcc branch has always been known to be more than just the equivalent mainline gcc version ...
Comment 13 Anonymous 2007-03-09 20:57:05 UTC
You couldn't know this, but I'm using mainline gcc here. Not apple's gcc variant. But it doesn't matter, this patch has been added to openssl cvs, so in a few weeks there will be a release with the fix. :) Sorry for the spam.
Comment 14 Ryan Hill (RETIRED) gentoo-dev 2007-03-10 03:03:15 UTC
Just to clarify, this patch is _not_ what went into CVS and will break stuff.  At this point I'm just going to wait for upstream to make a release as i feel nowhere near confident enough in backporting these changes in something as essential as openssl.
Comment 15 Ryan Hill (RETIRED) gentoo-dev 2007-05-15 01:52:04 UTC
Created attachment 119315 [details, diff]
openssl-0.9.8e-gcc42.patch

This is the patch I'm currently testing, credit PLD Linux.

vapier: i agree, we probably don't want to maintain this.  i'm just posting it here to refer people to.
Comment 16 SpanKY gentoo-dev 2007-05-24 04:58:07 UTC
*** Bug 179600 has been marked as a duplicate of this bug. ***
Comment 17 SpanKY gentoo-dev 2007-06-22 02:26:04 UTC
ive added the PLD patch for gcc-4.2 users only pending a real fix from upstream

thanks Ryan