Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 157586

Summary: games-engines/stratagus-2.1 flac 1.1.3 compatibility patch
Product: Gentoo Linux Reporter: Alexis Ballier <aballier>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal CC: sound
Priority: High    
Version: 2006.1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 152007    
Attachments: Patch from Josh Coalson

Description Alexis Ballier gentoo-dev 2006-12-09 02:16:08 UTC
Mail from Josh Coalson : 
"
hi devs, attached are patches to stratagus-2.1 to make the code
work with both the upcoming FLAC 1.1.3 release and previous
versions.  a beta of FLAC 1.1.3 is available here:
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download

changelog:
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html

the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated
everywhere.

I could not figure out what was the latest code in svn but I'm
guessing the patch also should work against.

let me know if you have any questions or problems...

Josh
"
Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be
correct.
Comment 1 Alexis Ballier gentoo-dev 2006-12-09 02:16:54 UTC
Created attachment 103668 [details, diff]
Patch from Josh Coalson
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2006-12-12 14:47:06 UTC
FIXED in CVS... I guess we can thank both Josh and you for putting forth all the work in getting all this going...