Bug 157005

Summary:	net-ftp/oftpd-0.3.7: Fix for ipv6 support
Product:	Gentoo Linux	Reporter:	Bruno <bonbons>
Component:	Current packages	Assignee:	Michael Weber (RETIRED) <xmw>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	beu
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch against oftpd-0.3.7 My current patch for IPv6 in oftpd oftpd-0.3.7-ipv6rel2-1.patch oftpd-0.3.7-family-1.patch oftpd-0.3.7-r4.ebuild ipvs patch

Description Bruno 2006-12-03 09:42:29 UTC

Since some time the ipv6 use-flag disappeared from net-ftp/oftpd because of compilation errors when enabled.

Here is a patch to make oftpd compile again with ipv6 support.

I did some checks locally (on x86, gcc4.1.1, glibc2.4):
- IPv6 only operation of oftpd
- IPv4 only operation of oftpd (with and without IPv6 support compiled in)
- IPv4+IPv6 operation (not mixed in a single FTP session)

As ftp clients I used wget (recursive downloads) and konqueror (browsing, 
downloads).

I also submitted this patch to upstream.

Comment 1 Bruno 2006-12-03 09:44:25 UTC

Created attachment 103284 [details, diff]
Patch against oftpd-0.3.7

Comment 2 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev

2009-11-27 12:29:48 UTC

what is the upstream status of this patch?

Comment 3 Bruno 2009-11-27 20:52:10 UTC

Created attachment 211361 [details, diff]
My current patch for IPv6 in oftpd

Back in december 2006 I got this reply from upstream:
"I'll have a closer look, and probably turn this into 0.3.8 some time
this week. Thanks!"

Unfortunately I've never seen a 0.3.8 release.

Note that with a recent glibc upgrade I've had some trouble with EAI_ADDRFAMILY no more being defined by default and attempts to set one of _POSIX_C_SOURCE,  _XOPEN_SOURCE or _POSIX_SOURCE (don't remember which one) I got compiling failures with things defined multiple times (I did define it just before the #include that are requested by getaddrinfo and I think I also tried at the top of the affected source file.

Comment 4 Mario Fetka (geos_one) 2010-02-20 22:21:29 UTC

Created attachment 220543 [details, diff]
oftpd-0.3.7-ipv6rel2-1.patch

 updated oftpd patch from ftp://ftp.deepspace6.net/pub/ds6/sources/oftpd/oftpd-0.3.6-ipv6rel2.patch.gz

Comment 5 Mario Fetka (geos_one) 2010-02-20 22:23:18 UTC

Created attachment 220545 [details, diff]
oftpd-0.3.7-family-1.patch

Updated family patch for the rcorresponding ipv6 patch

Comment 6 Mario Fetka (geos_one) 2010-02-20 22:25:36 UTC

Created attachment 220547 [details, diff]
oftpd-0.3.7-r4.ebuild ipvs patch

the ebuild changes

Comment 7 Michael Weber (RETIRED) gentoo-dev

2010-09-01 10:00:15 UTC

+*oftpd-0.3.7-r5 (01 Sep 2010)
+
+  01 Sep 2010; Michael Weber <xmw@gentoo.org> +oftpd-0.3.7-r5.ebuild,
+  +files/oftpd-0.3.7-family-1.patch,
+  +files/oftpd-0.3.7-ipv6rel2-0.3.6-to-0.3.7.patch, metadata.xml:
+  Revbump to re-add ipv6 support, fixes bug 157005, thanks to Bruno
+  <bonbons67@internet.lu> and Mario Fetka (geos_one) <mario.fetka@gmail.com>
+  for their work on this bug.