Summary: | games-mods.eclass bad built_with_use check | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paul Bredbury <brebs> |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | muczyjoe |
Priority: | High | ||
Version: | 2006.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Paul Bredbury
2006-11-24 21:11:19 UTC
Well, portage is definitely doing something wrong. Anyway, I've added the dedicated USE flag to ut2004's IUSE for the time being. I'll try to get this fixed properly the first of next week. *** Bug 158136 has been marked as a duplicate of this bug. *** I could have sworn I removed that check in the final eclass... anyway... FIXED. Reopened - if this is considered a dupe of bug #158136, then bug #158136 comment #2 still applies. games-mods_pkg_setup cannot perform checks on a package which is not yet installed. To make it work, it must DEPEND on $GAME rather than RDEPEND. Also, RDEPEND in the eclass has been commented out - why? Umm... why did you reopen this? It only does built_with_use checks *if* the package is installed. As for RDEPEND, it is commented due to circular dependencies. (In reply to comment #5) > It only does built_with_use checks *if* the package is installed. Exactly my point. Are these built_with_use checks important? Because they will *not* be performed if ut2004 is installed *after* e.g. ut2004-muralis. Since ut2004-muralis has deps: RDEPEND="${CATEGORY}/${GAME}" (from its ebuild) DEPEND="app-arch/unzip" (from games-mods eclass) Then it is possible that on a fresh installation, a person typing "emerge ut2004-muralis" with his UT2004 DVD ready, has those checks skipped. Which is bad if those checks have any purpose. This bug has not been resolved. So, I should reopen it, yes? Have I misunderstood how bugzilla works? The behavior is exactly what I intended (now). Please do not REOPEN this bug, as the eclass does exactly what I want it to do. |