Summary: | media-sound/ncmpc-0.11.1: patch to fix UTF8 issues | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sebastian <sebastian_ml> |
Component: | Current packages | Assignee: | Andrej Kacian (RETIRED) <ticho> |
Status: | RESOLVED TEST-REQUEST | ||
Severity: | minor | CC: | akira, sound |
Priority: | High | ||
Version: | 2006.1 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.musicpd.org/mantis/view.php?id=476 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ncmpc-utf.patch
ncmpc-0.11.1.ebuild ncmpc-utf.patch |
Description
Sebastian
2006-11-14 16:10:56 UTC
Created attachment 101956 [details, diff] ncmpc-utf.patch Details at http://www.musicpd.org/mantis/view.php?id=476 Created attachment 101957 [details]
ncmpc-0.11.1.ebuild
Updated ebuild, ncmpc works fine with the patch. Had issues with volume display, patch fixed that.
Patch seems to need some work, it uses libcursesw unconditionally for one. :-) Let's just wait for upstream's reaction here, shall we? Your call. I read that the ncmpc dev didn't surface for a long time (last ncmpc change according to svn was 2006-03-31) and that there's a ncmpc svn branch named tradiaz. I don't know wheter ncmpc will ever be maintained anymore at all or tradiaz will ever make a release. When I last spoke to tradiaz on IRC, I think he mentioned wanting to make a release. kaw (the original maintainer) appears from time to time, not very often. Thanks for the info. The client is way to nice to not get any attention. Created attachment 104831 [details, diff]
ncmpc-utf.patch
Comment on attachment 104831 [details, diff]
ncmpc-utf.patch
+russian charset fix
Ok, no point in waiting for upstream this long. I've applied the patch in 0.11.1-r2, please give it a try. I suspect the Russian message catalog doesn't get rebuilt after the patch. doesnt work for me because i dont want my ncurses lib to be compiled with unicode.. hence i dont have libncursesw on my system ... which leads to link error: gcc -mtune=i686 -O2 -pipe -Wl,-z,now,-O1 -o ncmpc libmpdclient.o main.o mpdclient.o options.o conf.o command.o screen.o screen_utils.o screen_play.o screen_file.o screen_search.o screen_help.o screen_keydef.o screen_clock.o list_window.o colors.o support.o wreadln.o strfsong.o utils.o -lglib-2.0 -lncursesw /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lncursesw collect2: ld returned 1 exit status make[2]: *** [ncmpc] Error 1 make[2]: Leaving directory `/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/work/ncmpc-0.11.1/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/work/ncmpc-0.11.1' make: *** [all] Error 2 !!! ERROR in media-sound/ncmpc-0.11.1-r2: !!! In src_compile at line 3473 !!! make failed !!! Call stack: !!! * src_compile (/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/temp/loadsaveenv:3473) !!! * ebuild_f_compile (/usr/libexec/paludis/src_compile.bash:51) !!! * ebuild_main (/usr/libexec/paludis/ebuild.bash:354) !!! * main (/usr/libexec/paludis/ebuild.bash:372) (In reply to comment #11) > doesnt work for me because i dont want my ncurses lib to be compiled with > unicode.. hence i dont have libncursesw on my system ... Right, I completely forgotten that libncursesw is optional. I've changed the ebuild to only be applied if ncurses has been built with unicode USE flag. Thanks. |