Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 153445

Summary: dev-python/mmpython-0.4.10 update
Product: Gentoo Linux Reporter: Ben <schleinzer>
Component: New packagesAssignee: Television related Applications in Gentoo's Portage <media-tv>
Status: RESOLVED FIXED    
Severity: enhancement CC: python
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 153447    
Attachments: mmpython-0.4.10.ebuild
Diff between 0.4.9 and 0.4.10
mmpython-0.4.10-missing_stdint_headers.patch
mmpython-0.4.10.ebuild

Description Ben 2006-10-30 07:46:43 UTC
Updated version of mmpython. Needed by freevo 1.6
Comment 1 Ben 2006-10-30 07:47:25 UTC
Created attachment 100793 [details]
mmpython-0.4.10.ebuild

Removed patch otherwise unchanged
Comment 2 Ben 2006-10-30 07:49:15 UTC
Created attachment 100794 [details, diff]
Diff between 0.4.9 and 0.4.10

Diff between 0.4.9 and 0.4.10
Comment 3 Matteo Azzali (RETIRED) gentoo-dev 2006-10-30 12:17:15 UTC
Created attachment 100816 [details, diff]
mmpython-0.4.10-missing_stdint_headers.patch

Some part of that patch still apply.....
Comment 4 Matteo Azzali (RETIRED) gentoo-dev 2006-10-30 12:24:28 UTC
Created attachment 100817 [details, diff]
mmpython-0.4.10.ebuild

Basically the same old ebuild renamed (renaming is the only diff).

Please don't blindly remove patches from the code when ebuilding version
bumps, if patches are there surely there's a good reason. 
If the patch for the old version does not apply this doesn't means
that anything has been fixed upstream but often that the right "entry points"
for patches are moved, for example for gentoo-specific patches.....
Comment 5 Ben 2006-10-31 04:01:08 UTC
The ebuild compiled and worked without the patch so I thought it is obsolete. 
Comment 6 Matteo Azzali (RETIRED) gentoo-dev 2006-10-31 07:15:11 UTC
I'm tempted to think the same, but I can test only in x86, not having means
to try it on sparc,ppc,ia64 or amd64 for which patches may be intended for... 

More details of this patch at bug #128314. Looking that it applied to 3
different versions of mmpython, we can guess that most of the systems were
compiling fine without the patch, while on some emersion was borked.
Chanches are that's depending on libdvdread. Being on an unstable system I
can guess just that libdvdread-0.9.7 doesn't gives this issue, so the patch
can be removed when 0.9.7 reaches stable branch. For any other assumption,
we would need further testing....
Comment 7 Matteo Azzali (RETIRED) gentoo-dev 2006-11-01 02:01:54 UTC
Actually in cvs.