Bug 152923

Summary:	sys-apps/hal doesn't handle indirections in copy_property in <append> and <prepend>
Product:	Gentoo Linux	Reporter:	Martin Parm <parmus>
Component:	Current packages	Assignee:	Project Gentopia <gentopia>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	2006.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Simple test case which illustrates the bug Fix for handling indirections in <append> and <prepend>

Description Martin Parm 2006-10-26 14:30:01 UTC

According to the HAL specs (http://gitweb.freedesktop.org/?p=hal.git;a=blob_plain;f=doc/spec/hal-spec.html#spec-device-info) should be able to handle indirections in copy_property in both <merge>, <append> and <prepend>-nodes, however only <merge> handles indirections right. A simple .fdi file which illustrates the problem will be posted shortly.
I've looked in the lastest source from the upstream repository, but it doesn't seem like they have fixed to problem yet either.

Comment 1 Martin Parm 2006-10-26 14:34:57 UTC

Created attachment 100556 [details]
Simple test case which illustrates the bug

This simple test case illustrates the bug with indirections in <append> and <prepend>. Simply put this file in /etc/hal/fdi/policy and plug in some removable storage-device (e.g an USB-key). If indirections in <append> and <prepend> had worked, volume.policy.desired_mount_point should be "usb_disk" for a USB-key.

Comment 2 Martin Parm 2006-10-26 14:39:24 UTC

Created attachment 100558 [details, diff]
Fix for handling indirections in <append> and <prepend>

This patch fixes the bug by correctly handling indirections in copy_property in <append> and <prepend>. It also simplifies the code a bit by merging the append and prepend handling code, as they are nearly identical anyway. The patch has been made with sys-apps/hal-0.5.7-r3 but also works with sys-hal-0.5.7.1-r1 without any changes.

Comment 3 Doug Goldstein (RETIRED) gentoo-dev

2007-01-30 16:14:19 UTC

Have you passed this upstream? Please reference where you passed it upstream.

Comment 4 Martin Parm 2007-02-02 12:44:12 UTC

(In reply to comment #3)
> Have you passed this upstream? Please reference where you passed it upstream.

OK, I passed it upstream now: https://bugs.freedesktop.org/show_bug.cgi?id=9849

However I don't have any high hopes. The last time I tried to get in touch with the HAL-developers they simply ignored me.

Comment 5 Doug Goldstein (RETIRED) gentoo-dev

2007-02-13 03:55:44 UTC

Added in -r5. Good job on this.