| Summary: | kde-base/kdelibs-3.5.2/3 KSSL weak cipher vulnerability | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Gentoo Security | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> | ||||||||
| Component: | Vulnerabilities | Assignee: | Gentoo Security <security> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | minor | CC: | corsair, dertobi123, gustavoz, killerfox, tcort, tsunam | ||||||||
| Priority: | High | ||||||||||
| Version: | unspecified | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | A4? [noglsa] jaervosz | ||||||||||
| Package list: | Runtime testing required: | --- | |||||||||
| Bug Depends on: | 147570 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Diego Elio Pettenò (RETIRED)
2006-10-20 12:13:32 UTC
From: Dirk Mueller <mueller@kde.org> To: kde-packager@kde.org CC: security@kde.org Date: Yesterday 23:40:00 I'm writing an advisory now anyway, but it is not a security vulnerability per se, as it depends on a server configuration that allows to negotiate weak ciphers even if stronger ones are available. This advisory comes rather late as it took some time to make sure that the patch remains regression free and fixes all issues that were found. Affected: All KDE versions up to including KDE 3.5.3. KDE 3.5.4 and 3.5.5 are unaffected. Overview: KSSL might decide to negotiate a weak cipher with a remote server even though the remote server supports a stronger one. In addition upgrade handling between SSLv3 / TLSv1 was broken, which caused it to use SSLv3 even if TLSv1 was possible, and to not connect at all if the server only supported TLSv1. There are three bugs: a) KDE 3.5.x by accident sorted the list of ciphers to try in alphabetic order, rather than by "strength indicator". b) older KDE versions did not sort them at all but picked the server order, which seems to be not sorted by strength. c) The "Use TLSv1 if server supports it" checkbox in KSSL configuration didn't quite work like intended. Created attachment 100100 [details, diff]
fix-weak-ciphers.diff
Created attachment 100101 [details]
kdelibs-3.5.2-r6.ebuild
Ok liaisons, you know the drill: please test and report back, dont commit anything yet. Thanks! patch needs to be renamed to kdelibs-3.5.2-fix-weak-ciphers.patch, although it fails to apply: patching file kio/kssl/ksslsettings.cc Hunk #1 FAILED at 179. 1 out of 1 hunk FAILED -- saving rejects to file kio/kssl/ksslsettings.cc.rej (ebuild should be -r7, not -r6?) Err I think I did a mess with the patches, hold on a second. Created attachment 100124 [details, diff]
kdelibs-3.5.2-fix-weak-ciphers.patch
It was less of a mess than I was afraid of :) Simply forgot to attach the patch used by the ebuild and simply attached the official one :P
One hunk is removed because was related to a change in 3.5.2->3 that was being reversed.
looks good on amd64. looks good on ppc64, too. looks ok on sparc. x86 seems to be fine here in x86 land. works for ppc. Works on hppa What's about the disclosure of that bug? I've seen a Suse fix that talks about this issue but that's all, and no advisory (and it's not a big security issue). The Suse bug is still closed : https://bugzilla.novell.com/show_bug.cgi?id=181169 Any news from here ? (release date for example) I was waiting for Mueller to say something else on the topic but seen nothing. I'd be looking forward tonight for adding this then, with the stables present. Looks good on Alpha. (In reply to comment #13) > What's about the disclosure of that bug? I've seen a Suse fix that talks about > this issue but that's all, and no advisory (and it's not a big security issue). Is this fix public? If so, they leaked it first and we can probably do a sneaky commit (no suspicious words in the commit-msg)? > On Tuesday 07 November 2006 11:42, Ismail Donmez wrote:
>
> > Dirk when do you intend to apply this?
>
> The patch has been developed in SVN and applied for KDE 3.5.4, which was
> released a few months ago. This was a mere notice that if you ship an older
> version of KDE (you shouldn't) you might consider applying this fix.
So, kdelibs-3.5.5 is being marked stable... I suppose this means that this bug is pointless as soon as the security supported arches mark 3.5.5 stable. Yeah, I'll close this one when it is all stable. Everything but mips is done, and mips is not security supported, IIRC. kdelibs 3.5.2 is no more in the tree. Security please close :) asusualfeelfreetoreopenifyoudisagreeblabla |