Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 151091

Summary: dev-db/postgresql-8.0.8 'threads' USE flag is missing
Product: Gentoo Linux Reporter: Andrew Kay <drew.kay>
Component: New packagesAssignee: PgSQL Bugs <pgsql-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: esigra
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=868393
Whiteboard:
Package list:
Runtime testing required: ---

Description Andrew Kay 2006-10-12 17:11:53 UTC
The above noted package is missing the 'threads' use flag found on 7.4.13 && 8.1.4 ebuilds.

Suggested Patch:
rikku # diff -Naru /usr/portage/dev-db/postgresql/postgresql-8.0.8.ebuild /usr/local/portage/dev-db/postgresql/postgresql-8.0.8.ebuild
--- /usr/portage/dev-db/postgresql/postgresql-8.0.8.ebuild      2006-10-12 16:28:36.000000000 -0700
+++ /usr/local/portage/dev-db/postgresql/postgresql-8.0.8.ebuild        2006-10-12 16:33:31.000000000 -0700
@@ -17,7 +17,7 @@
 LICENSE="POSTGRESQL"
 SLOT="0"
 KEYWORDS="alpha amd64 arm hppa ia64 mips ppc ppc64 s390 sh sparc x86"
-IUSE="ssl nls python tcl tk perl libg++ pam readline xml zlib doc selinux kerberos pg-intdatetime pg-hier"
+IUSE="ssl nls python tcl tk perl libg++ pam readline xml zlib doc selinux kerberos pg-intdatetime pg-hier threads"

 S=${WORKDIR}/${MY_P}
 DEPEND="virtual/libc
@@ -91,6 +91,7 @@
        use zlib || myconf="$myconf --without-zlib"
        use kerberos && myconf="$myconf --with-krb5"
        use pg-intdatetime && myconf="$myconf --enable-integer-datetimes"
+       use threads && myconf="$myconf --enable-thread-safety"

        # these are the only working CFLAGS I could get on ppc, so locking them
        # down, anything more aggressive fails (i.e. -mcpu or -Ox)
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-10-13 01:09:12 UTC
You'd need to update libpq as well... Plus this is actually missing intentionally.
Comment 2 Andrew Kay 2006-10-13 16:27:32 UTC
For what reason was the threads flag removed intentionally? I've tried to find a reason in various gentoo & upstream lists why the underlying flag shouldn't be used in 8.0.8 however I've come up empty handed and now stand confused why 7.4.13 && 8.1.4 have the flag but 8.0.8 doesn't.

Also, am I correct in infering that postgresql && libpg need to have this flag mutually set if they're to work together correctly? If so, libpq-7.4.13 needs to have the threads flag added OR postgresql-7.4.13 needs the flag removed. If you want I'll submit a new bug request w/ patches to address it.
Comment 3 Luca Longinotti (RETIRED) gentoo-dev 2006-10-13 16:49:32 UTC
Please leave this opened, we know there is the problem with the threads flag, we've fixed it in the PostgreSQL Overlay (overlays.gentoo.org/proj/postgresql), but those ebuilds are still a little bit off until they are ready for usage.
Basically the right solution is to add the threads USE flag to libpq 7.4, 8.0 and 8.1 releases, not to libpq 7.3 too since that has no threads support, and also not to postgresql itself as only the library can be compiled threadsafe, the server/clients are all process-based (non-threading).
Best regards, CHTEKK.
Comment 4 Luca Longinotti (RETIRED) gentoo-dev 2006-11-07 14:57:16 UTC
Ebuilds for versions 7.3.16, 7.4.14, 8.0.9 and 8.1.5 of libpq and postgresql just hit Portage, those fix this correctly: only libpq 7.4, 8.0 and 8.1 releases now have a "threads" USE flag.
Best regards, CHTEKK.