Bug 150584

Summary:	epiphany-2.14.2.1-r1 (and other versions?) compile fix against firefox-2.0_rc2
Product:	Gentoo Linux	Reporter:	Ari Rahikkala <ari.rahikkala>
Component:	Current packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Compile fix patch

Description Ari Rahikkala 2006-10-09 08:23:01 UTC

i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../lib -I../../embed -I../.. -I/usr/lib/mozilla-firefox/include -I/usr/lib/mozilla-firefox/include/caps -I/usr/lib/mozilla-firefox/include/chardet -I/usr/lib/mozilla-firefox/include/chrome -I/usr/lib/mozilla-firefox/include/commandhandler -I/usr/lib/mozilla-firefox/include/content -I/usr/lib/mozilla-firefox/include/cookie -I/usr/lib/mozilla-firefox/include/docshell -I/usr/lib/mozilla-firefox/include/dom -I/usr/lib/mozilla-firefox/include/exthandler -I/usr/lib/mozilla-firefox/include/fastfind -I/usr/lib/mozilla-firefox/include/helperAppDlg -I/usr/lib/mozilla-firefox/include/gfx -I/usr/lib/mozilla-firefox/include/gtkembedmoz -I/usr/lib/mozilla-firefox/include/history -I/usr/lib/mozilla-firefox/include/js -I/usr/lib/mozilla-firefox/include/layout -I/usr/lib/mozilla-firefox/include/locale -I/usr/lib/mozilla-firefox/include/mimetype -I/usr/lib/mozilla-firefox/include/necko -I/usr/lib/mozilla-firefox/include/nkcache -I/usr/lib/mozilla-firefox/include/passwordmgr -I/usr/lib/mozilla-firefox/include/pipboot -I/usr/lib/mozilla-firefox/include/pipnss -I/usr/lib/mozilla-firefox/include/shistory -I/usr/lib/mozilla-firefox/include/sidebar -I/usr/lib/mozilla-firefox/include/uriloader -I/usr/lib/mozilla-firefox/include/uconv -I/usr/lib/mozilla-firefox/include/wallet -I/usr/lib/mozilla-firefox/include/webbrowserpersist -I/usr/lib/mozilla-firefox/include/webbrwsr -I/usr/lib/mozilla-firefox/include/widget -I/usr/lib/mozilla-firefox/include/windowwatcher -I/usr/lib/mozilla-firefox/include/xmlextras -I/usr/lib/mozilla-firefox/include/xpcom -I/usr/lib/mozilla-firefox/include/xpconnect -I/usr/lib/mozilla-firefox/include/find -I/usr/lib/mozilla-firefox/include/pref -DSHARE_DIR=\"/usr/share/epiphany\" -DPLUGINDIR=\"/usr/lib/epiphany/2.14/plugins\" -DMOZILLA_HOME=\"/usr/lib/mozilla-firefox\" -DMOZILLA_PREFIX=\"/usr\" -DEPIPHANY_MAJOR=\"2.14\" -DALLOW_PRIVATE_API -I/usr/lib/mozilla-firefox/include -I/usr/lib/mozilla-firefox/include/xpcom -I/usr/lib/mozilla-firefox/include/string -I/usr/include/nspr -I/usr/lib/mozilla-firefox/include/gtkembedmoz -DORBIT2=1 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -I/usr/include/gnome-desktop-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/libgnomeprint-2.2 -I/usr/include/libgnomeprintui-2.2 -fno-rtti -fshort-wchar -O2 -march=athlon-xp -pipe -g -Wall -Wno-unused -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -O2 -march=athlon-xp -pipe -g -MT libephymozillaembed_la-EphySidebar.lo -MD -MP -MF .deps/libephymozillaembed_la-EphySidebar.Tpo -c EphySidebar.cpp  -fPIC -DPIC -o .libs/libephymozillaembed_la-EphySidebar.o
EphySidebar.cpp:110: error: no 'nsresult EphySidebar::AddMicrosummaryGenerator(const char*)' member function declared in class 'EphySidebar'
make[4]: *** [libephymozillaembed_la-EphySidebar.lo] Error 1
make[4]: Leaving directory `/var/tmp/portage/epiphany-2.14.2.1-r1/work/epiphany-2.14.2.1/embed/mozilla'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/epiphany-2.14.2.1-r1/work/epiphany-2.14.2.1/embed'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/epiphany-2.14.2.1-r1/work/epiphany-2.14.2.1/embed'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/epiphany-2.14.2.1-r1/work/epiphany-2.14.2.1'
make: *** [all] Error 2

!!! ERROR: www-client/epiphany-2.14.2.1-r1 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_compile
  ebuild.sh, line 937:   Called src_compile
  epiphany-2.14.2.1-r1.ebuild, line 95:   Called gnome2_src_compile
  gnome2.eclass, line 64:   Called die



Obvious cause: AddMicrosummaryGenerator is defined conditionally on HAVE_GECKO_1_8_1 in EphySideBar.cpp, but never declared anywhere in the Epiphany sources at all. Patch to conditionally declare AddMicrosummaryGenerator in EphySidebar.h follows, I'm not sure if it's the right thing to do but it does make the thing compile.

Comment 1 Ari Rahikkala 2006-10-09 08:24:40 UTC

Created attachment 99207 [details, diff]
Compile fix patch

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2006-10-09 10:43:46 UTC

>=2.16.0 doesn't need any patch.

*** This bug has been marked as a duplicate of 149104 ***