Bug 150583

Summary:	dev-libs/glib-2.12.4 fails compiling a test on g/fbsd
Product:	Gentoo/Alt	Reporter:	Javier Villavicencio (RETIRED) <the_paya>
Component:	FreeBSD	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bsd+disabled
Priority:	High
Version:	unspecified
Hardware:	All
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	glib -pthread.diff

Description Javier Villavicencio (RETIRED) gentoo-dev

2006-10-09 08:07:16 UTC

glib fails linking errorcheck-mutex-test during the main compilation (not during test as in FEATURES=test).
The reason it fails on g/fbsd is that -pthread has to be specified during the final binary linkage, more info about 'why' here: http://xrl.us/r6gm
On older versions of glib, while linking these tests, those who required libgthread where implicitly adding $(G_THREAD_LIBS) to their link command, this new one (errorcheck-mutex-test) is not doing so, even as it adds libgthread as the others do.
The attached patch fixes this without requiring to run eautoreconf, because the automake rerun fails.

Comment 1 Javier Villavicencio (RETIRED) gentoo-dev

2006-10-09 08:08:35 UTC

Created attachment 99202 [details, diff]
glib -pthread.diff

Proposed fix.

Comment 2 Simon Koenig 2006-10-15 02:52:12 UTC

This patch works fine for me. Thanks.

(In reply to comment #1)
> Created an attachment (id=99202) [edit]
> glib -pthread.diff
> 
> Proposed fix.
>

Comment 3 Mart Raudsepp gentoo-dev

2006-10-15 07:08:57 UTC

Committed to 2.12.4 without revbump. Thanks