Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 150217

Summary: ebuild for vdrrip with UGLY patch to cope with problems caused by newer versions of mplayer used by gentoo
Product: Gentoo Linux Reporter: E. Scaglione <erm67>
Component: New packagesAssignee: Gentoo VDR Project <vdr>
Status: RESOLVED FIXED    
Severity: enhancement CC: vdr
Priority: High Keywords: EBUILD
Version: 2006.1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: vdr-vdrrip-0.3.0-r2.ebuild
confd
vdrrip-0.3.0-1.3.7.diff
mplayercmd.diff
vdrrip-qh
vdrrip-qh.conf
ebuild with patches from debian experimental ported
detectlength.diff
fix-ogm-ac3-vdrsync-dev.diff
greppid2.diff
maketempdir.diff
mplayercmd.diff
fixpreview.diff
mencoderparam.diff
preserve-queue-owner.diff
log-patch.diff
vdr-vdrrip-0.3.0-r4.ebuild
vdrrip-qh.conf
mencoderparam.diff
mplayercmd2.diff

Description E. Scaglione 2006-10-05 16:05:06 UTC
This is a port of the ebuild from the gentoo.de overlay with a patch to fix2 problems caused by the version of mplayer used in gentoo. In particular the newer mplayer no longer return the aspect ratio of a dvb stream so the patch fixes it to 4:3, of course this only works if the stream really has 4:3 aspect ratio (and this is the case for most channels). 
The second patch eliminates the -really-quiet parameter from the mplayer command used to crop the black boarders, the newer versions infact doesn't return crop informations with this parameter.
Now it works well on my vdr :-)


http://www.vdr-portal.de/board/thread.php?threadid=53225&hilight=vdrrip
Comment 1 E. Scaglione 2006-10-05 16:09:18 UTC
Created attachment 98891 [details]
vdr-vdrrip-0.3.0-r2.ebuild
Comment 2 E. Scaglione 2006-10-05 16:09:44 UTC
Created attachment 98892 [details]
confd
Comment 3 E. Scaglione 2006-10-05 16:10:15 UTC
Created attachment 98893 [details, diff]
vdrrip-0.3.0-1.3.7.diff
Comment 4 E. Scaglione 2006-10-05 16:10:34 UTC
Created attachment 98894 [details, diff]
mplayercmd.diff
Comment 5 E. Scaglione 2006-10-05 16:11:00 UTC
Created attachment 98895 [details]
vdrrip-qh
Comment 6 E. Scaglione 2006-10-05 16:11:22 UTC
Created attachment 98896 [details]
vdrrip-qh.conf
Comment 7 E. Scaglione 2006-10-06 00:06:48 UTC
Created attachment 98905 [details]
ebuild with patches from debian experimental ported
Comment 8 E. Scaglione 2006-10-06 00:07:18 UTC
Created attachment 98906 [details, diff]
detectlength.diff
Comment 9 E. Scaglione 2006-10-06 00:07:37 UTC
Created attachment 98907 [details, diff]
fix-ogm-ac3-vdrsync-dev.diff
Comment 10 E. Scaglione 2006-10-06 00:07:58 UTC
Created attachment 98908 [details, diff]
greppid2.diff
Comment 11 E. Scaglione 2006-10-06 00:08:21 UTC
Created attachment 98909 [details, diff]
maketempdir.diff
Comment 12 E. Scaglione 2006-10-06 00:45:19 UTC
Created attachment 98911 [details, diff]
mplayercmd.diff

small change, only fix aspect ratio if mplayer returns 0
Comment 13 E. Scaglione 2006-10-06 15:21:58 UTC
Created attachment 99010 [details, diff]
fixpreview.diff
Comment 14 E. Scaglione 2006-10-06 15:41:31 UTC
Created attachment 99011 [details, diff]
mencoderparam.diff

new patch submitted to author but did't get any answer.
Comment 15 E. Scaglione 2006-10-07 01:52:37 UTC
One of the two problems fixed by UGLY patch2 was fixed by the mplayer upstream and should be soon in in the current svn version of mplayer and so it will be hopefully fixed in the next release, the patch however checks the value returned by mplayer and only forces it to 4:3 if is 0.000 so it is probably a good idea to keep it, maybe adding a warning message.
Comment 16 E. Scaglione 2006-10-08 09:56:00 UTC
Comment on attachment 98896 [details]
vdrrip-qh.conf

# /etc/conf.d/vdrrip-qh
# Distributed under the terms of the GNU General Public License, v2 or later
# $Header: /var/cvsroot/gentoo-x86/media-plugins/vdr-vdrrip/files/vdrrip-qh.conf,v 1.1 2005/11/20 20:35:02 zzam Exp $

USER="root"

LOGFILE="/var/log/vdrrip-qh"

TEMPDIR="/tmp/vdrrip"

QUEUE="/etc/vdr/plugins/queue.vdrrip"
Comment 17 E. Scaglione 2006-10-08 10:45:56 UTC
Created attachment 99142 [details, diff]
preserve-queue-owner.diff

Another patch from Debian Required otherwise the script changes the ownership of the queue file after the encoding and vdr can no longer access it.
Comment 18 E. Scaglione 2006-10-11 11:40:12 UTC
Created attachment 99378 [details, diff]
log-patch.diff

yet another patch to vdrrip-qh without it nothing is logged
Comment 19 E. Scaglione 2006-10-11 11:41:06 UTC
Created attachment 99379 [details]
vdr-vdrrip-0.3.0-r4.ebuild

latest ebuild with all patches
Comment 20 Matthias Schwarzott gentoo-dev 2006-10-12 13:51:31 UTC
Can someone please rename the attachments to usefull names!
"from debian" is no good name for a patch.
Comment 21 Joerg Bornkessel (RETIRED) gentoo-dev 2006-10-12 14:06:38 UTC
picup this bug to gentoo VDR project
Comment 22 E. Scaglione 2006-10-13 11:58:13 UTC
Comment on attachment 99011 [details, diff]
mencoderparam.diff

patch by me to fix motion detection artifacts encoding interlaced streams
Comment 23 E. Scaglione 2006-10-13 12:37:32 UTC
Created attachment 99579 [details]
vdrrip-qh.conf

queue parameter added
Comment 24 Matthias Schwarzott gentoo-dev 2006-10-13 13:14:54 UTC
commited to CVS.
Thanks to erm67 for providing the ebuild and also for proxy-maintaining it :)
Comment 25 E. Scaglione 2006-10-13 15:08:36 UTC
Created attachment 99599 [details, diff]
mencoderparam.diff

small typo
Comment 26 E. Scaglione 2006-11-05 15:23:25 UTC
Created attachment 101310 [details, diff]
mplayercmd2.diff

Fixes definitel the VIDEO_ASPECT problem and works with newer and older versions of mplayer
Comment 27 E. Scaglione 2006-11-05 15:25:37 UTC
the plugin still does not work with the newest mplayer the patch mplayercmd2.diff should definitely fix the problem. I searches the first occurrence of ID_VIDEO_ASPECT not 0 and if cannot find it sets Aspect to 1.333
Comment 28 Matthias Schwarzott gentoo-dev 2006-11-06 02:05:04 UTC
Also added last mplayercmd2.diff to ebuild.