Bug 149746 – New KDEPrint 3.5.4 CUPS 1.2.x Patch to Enhance Compatibility.

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jon 2006-10-01 09:35:13 UTC]

Hi,

I was reading through bugs.kde.org, and the URL that I linked with this report has a post dated 2006-09-20 with additional patches that went into the KDE SVN. So, I checked out all code in the kdelibs/kdeprint/cups directory and diffed that with the code from KDELibs 3.5.4 tarball. I went through the patch and noticed some nice changes for CUPS 1.2.x. These changes are official and should appear in the next release of KDELibs (3.5.5?). They did things slightly different than the current patches from Kubuntu. I do believe that things are done in a better way. In fact, the code is compatible with both CUPS 1.2.x and 1.1.x versions. So, this can be applied without checks to see which version of CUPS is used. However, I do not know if any of the changes from the kubuntu patches need to be added or not. Though, one needs to go through and see by hand what all the changes are and to see if a certain change from kubuntu is needed. If anything, this will prepare you for the release of KDE 3.5.5 and making CUPS 1.2.x work with it. I have had nothing but trouble with CUPS 1.2.x, so can you please look at this and try to get this out in the next revision with kubuntu patches (if needed)? This would be helpful to me and I think to others. I hope the patch is in the correct format and is correctly done. I went through it and didn't see anything that would hurt, but then you know more than I do about this.

Thanks.
Jon

[Comment 1 Jon 2006-10-01 09:36:24 UTC]

Created attachment 98530 [details, diff]
kdelibs-3.5.4-kdelibs-cups.patch

This is the new patch. I hope you can use it. It's suppose to fix a lot of remaining issues. :)

Cheers.

[Comment 2 Diego Elio Pettenò (RETIRED) 2006-10-01 09:56:22 UTC]

KDE 3.5.5 is not far off, I don't think it's worth the hassle to actually swap around the patches, unless you have a particular problem that you can say it's fixed with this patch.

[Comment 3 Jonathan Callen (RETIRED) 2009-10-17 08:49:32 UTC]

reopening to change resolution

[Comment 4 Jonathan Callen (RETIRED) 2009-10-17 08:50:47 UTC]

this has been fixed in 3.5.10 (or earlier) and in 4.x